Git Patch BoringSSL to disable Windows build warnings/errors #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DellaBitta
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
DellaBitta
changed the title
firebase-workflow-trigger
bot
removed
the
tests: in-progress
DellaBitta
added
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
|
Tests failed during a download of the cloud sdk and not in any of the build steps. Packaging flow was fully succesful. |
DellaBitta
added a commit
that referenced
this pull request
Jun 15, 2021
Windows BoringSSL builds are now larger due to #454. The checkout & build partition **(D:)** hits capacity when attempting to install the Google Cloud SDK, which is what we use to upload the final integraion_test build artifacts to storage. This change moves the arhives destined for GCS to the **C:** drive, then installs the Cloud SDK after they're off of **D:**. The migration of the integration tests only occurs on Windows, for now. Some notes: - We can’t set the build_testapps.py’s --output_directory flag to directly output to the **C:** directory because python’s relpath operations fail when working across different drives. - The **github.workspace** env var can be changed to override check-out & installation paths, but the [GHA team notes potential unknown side effects](https://github.community/t/is-it-possible-to-change-github-workspace/136094/3). Therefore I didn’t test this. - We couldn't use **mv** the results to **C:** as Firestore's build results include symlinks. Using **tar** to ferry the files instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the boringSSL sources so that they no longer causes warnings on
windows-latestrunners.Other tests: