Skip to content

Feature/tvos support #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 3, 2021
Merged

Feature/tvos support #443

merged 18 commits into from
Jun 3, 2021

Conversation

vimanyu
Copy link
Contributor

@vimanyu vimanyu commented Jun 2, 2021 •
edited
Loading

This is specifically for building tvOS libraries for both device and simulator. For testing the built libraries, there will be another PR that ensures all integration tests are working.

  • single toolchain file that could possibly be used in the future for iOS as well as mac builds. Currently being used only for tvOS.
  • Disabled AdMob and Dynamic Links as they are not supported on tvOS.
  • Disabled some functionality from auth (PhoneAuthProvider) that doesn't exist on tvOS.
  • Disabled some functionality in FCM (since some of the frameworks we are using do not exist on tvOS). FCM might require more work for full functionality on tvOS but it doesn't block the builds.

Easiest way to build for tvos (including xcframeworks) is to use the helper bash scripts,
build_scripts/tvos/build.sh

vimanyu added 13 commits May 19, 2021 11:44
@vimanyu
cmake toolchain for tvos/ios/macos
0999e48 
Plan to use it only for tvos first.
@vimanyu
passthrough PLATFORM variable to sub builds
0092bba 
For tvos and other apple platforms, "PLATFORM" cmake variable
is set. We want to pass this through to sub-builds to build external
depenedencies.
@vimanyu
new platform preprocessor constant FIREBASE_PLATFORM_TVOS
bc4905d
@vimanyu
disable app invites on tvos
93ab80c 
FDL does not work on tvos. Do not use app invites on tvos.
@vimanyu
removing some functionality that is missing natively on tvos
2ec7a6b 
Some features like phone auth are only available on iOS and are missing
on tvOS.
@vimanyu
reordering import to ensure preprocessor variables are set
bb8cb77
@vimanyu
better way of disabling phone auth on tvos
d5c790d 
We treat it like desktop stub.
@vimanyu
removing unsupported functionality from tvos
d661e9f
@vimanyu
disable AdMob on tvOS
7de9fd5
@vimanyu
disable FDL for tvos simulator as it is not supported
cbf1c20
@vimanyu
fixed tvos configs
62ffb4e
@vimanyu
tvos simulator config is only x86_64
f4d664b
@vimanyu
disable dynamic links build on tvos.
89b331d
@vimanyu vimanyu requested review from jonsimantov and DellaBitta June 2, 2021 19:25
@vimanyu vimanyu self-assigned this Jun 2, 2021
@google-cla google-cla bot added the cla: yes label Jun 2, 2021
DellaBitta
DellaBitta requested changes Jun 2, 2021
View reviewed changes
@vimanyu
Copy link
Contributor Author

vimanyu commented Jun 3, 2021

Thanks for the comments! All have been addressed!

@vimanyu vimanyu requested a review from DellaBitta June 3, 2021 19:29
DellaBitta
DellaBitta requested changes Jun 3, 2021
View reviewed changes
@vimanyu vimanyu requested a review from DellaBitta June 3, 2021 20:11
@vimanyu vimanyu merged commit fa07fae into main Jun 3, 2021
@vimanyu vimanyu deleted the feature/tvos-support branch June 3, 2021 20:46
@firebase firebase locked and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees

@vimanyu vimanyu

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimanyu @DellaBitta