Skip to content

More accurate error reporting when an Auth error occurs. #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2021

Conversation

ehsannas
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label May 26, 2021
@ehsannas ehsannas requested a review from dconeybe May 26, 2021 21:07
@ehsannas
Copy link
Contributor Author

ehsannas commented May 26, 2021

Looks like clang-format made a couple of minor changes in this PR. I'm using clang-format version 12.0.0.

@dconeybe dconeybe assigned ehsannas and unassigned dconeybe May 27, 2021
@ehsannas ehsannas requested a review from dconeybe May 27, 2021 15:48
@ehsannas ehsannas assigned dconeybe and unassigned ehsannas May 27, 2021
dconeybe
dconeybe previously approved these changes May 27, 2021
@dconeybe dconeybe assigned ehsannas and unassigned dconeybe May 27, 2021
@dconeybe dconeybe assigned ehsannas and unassigned dconeybe May 27, 2021
@ehsannas ehsannas added the tests-requested: quick Trigger a quick set of integration tests. label May 27, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 27, 2021
@github-actions
Copy link

github-actions bot commented May 27, 2021

✅  Integration test succeeded!

Requested by @ehsannas on commit 31645d6
Last updated: Thu May 27 10:58:46 PDT 2021
View integration test results

@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 27, 2021
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 27, 2021
@ehsannas ehsannas merged commit be689ab into main May 27, 2021
@ehsannas ehsannas deleted the ehsann-better-errors branch May 27, 2021 19:57
@firebase firebase locked and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants