Converted RegistrationIntentService to a JobIntentService #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be a hard-to-reproduce hang that in the RegistrationIntentService, which is probably related to it being an IntentService instead of a JobIntentService.
alexames
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
a-maurice
reviewed
May 27, 2021
messaging/src/android/java/com/google/firebase/messaging/cpp/RegistrationIntentService.java
Outdated
Show resolved
Hide resolved
DellaBitta
requested changes
Jun 3, 2021
messaging/src/android/java/com/google/firebase/messaging/cpp/RegistrationIntentService.java
Show resolved
Hide resolved
DellaBitta
added
tests-requested: quick
github-actions
bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @DellaBitta on commit 3aeff9b |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
github-actions
bot
added
the
tests: succeeded
DellaBitta
approved these changes
Jun 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a hard-to-reproduce hang that in the
RegistrationIntentService, which is probably related to it being an
IntentService instead of a JobIntentService.