Code Format using clang-format's Google style defaults. #383
Conversation
DellaBitta
changed the title
app/src/locale.cc
Outdated
| : getenv("LC_CTYPE") | ||
| ? getenv("LC_CTYPE") | ||
| : getenv("TEST_TMPDIR") ? "en_US" : ""; | ||
| std::string output = std::locale().name() != "C" ? std::locale().name() |
There was a problem hiding this comment.
nit: This is a case where I think the formatter is going to do worse than the nicely formatted table no matter what settings we use. If we go through with committing with these settings, can this block get wrapped in // clang-format off/on?
app/tests/optional_test.cc
Outdated
| .Construct(1) | ||
| .CopyAndMove(2, 1) | ||
| .Destruct(4); | ||
| SetupExpectCall().Construct(1).CopyAndMove(2, 1).Destruct(4); |
There was a problem hiding this comment.
As mentioned above, I think this is a case where having the manual formatting is arguably superior (though I feel less strongly about this one). Another // clang-format off/on?
There was a problem hiding this comment.
Done.
Also found a few more.
|
Added some clang-format on / off toggles around code which flows better in the authored state. |
DellaBitta
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @DellaBitta on commit f27d696 |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
github-actions
bot
added
the
tests: succeeded
There was a problem hiding this comment.
This looks good to me. The one minor nitpick I have is that I'm not a huge fan of when the formatter decides to line up comments at the end of lines, because it can end up with some awkwardly formatted comments, but I don't think it's worth overriding google style to turn that off.
Yeah, I saw this too and it made me sigh. |
Updated codebase using clang-format's Google style basis without any further one-off customizations.
Clang-format seemingly. does some odd things to objective-c files. Therefore directories known to contain objective-c files are ignored by defining a local .clang-format file which disables clang-format. Objective C .mm files are ignored in mixed-language directories, and Obj-C headers are detected by the format_code.py script which search for Obj-c language tags.