Skip to content

Switch to a Firestore commit that fixes a Windows build error. #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 13, 2021

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Apr 13, 2021

This fixes a Windows build error in Firestore's core library.
Also fix log summarization (as a minor change) on Android.

@google-cla google-cla bot added the cla: yes label Apr 13, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 13, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 13, 2021
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 13, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 13, 2021
@github-actions github-actions bot removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 13, 2021
@github-actions
Copy link

github-actions bot commented Apr 13, 2021

❌  Integration test FAILED

Requested by @jonsimantov on commit 0e0778e
Last updated: Tue Apr 13 00:58:09 PDT 2021
View integration test results

Platform Build failures Test failures
iOS (built on MacOS) storage

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 13, 2021
@jonsimantov jonsimantov changed the title Add -DNOMINMAX to Firestore Core. Switch to a Firestore commit that fixes a Windows build error. Apr 13, 2021
@jonsimantov jonsimantov merged commit 872b8ca into main Apr 13, 2021
@jonsimantov jonsimantov deleted the fix/firestore-windows-minmax branch April 13, 2021 07:30
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 13, 2021
@firebase firebase locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant