Skip to content

Temporarily disable the multithreaded delete test in the AdMob integration test. #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Temporarily disable the multithreaded delete test in the AdMob integration test. #260

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26482dc
Temporarily disable the multithreaded delete test in the AdMob integr…
jonsimantov Jan 28, 2021
96e80c3
Fix comment formatting.
jonsimantov Jan 28, 2021
57a2541
Merge branch 'dev' into feature/js-disable-flaky-admob-test
jonsimantov Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions admob/integration_test/src/integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@ static void* DeleteBannerViewOnSignal(void* args) {

TEST_F(FirebaseAdMobTest, TestBannerViewMultithreadDeletion) {
SKIP_TEST_ON_DESKTOP;
SKIP_TEST_ON_MOBILE; // TODO(b/172832275): This test is temporarily // disabled on all platforms due to flakiness // on Android. Once it's fixed, this test should // be re-enabled on mobile.

static const int kBannerWidth = 320;
static const int kBannerHeight = 50;
Expand Down