Skip to content

Firestore: add helper functions for integration testing Java exceptions in Android #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2023
Merged

Firestore: add helper functions for integration testing Java exceptions in Android #1346

merged 2 commits into from
Jun 20, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jun 9, 2023

Add member functions to FirestoreAndroidIntegrationTest: CreateException() and ThrowException(), as well as the RefersToSameJavaObjectAs googlemock matcher.

@dconeybe dconeybe added api: firestore skip-release-notes Skip release notes check labels Jun 9, 2023
@dconeybe dconeybe self-assigned this Jun 9, 2023
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Jun 9, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @wu-hui on commit b63708a
Last updated: Tue Jun 20 10:31 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 9, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 9, 2023
@dconeybe dconeybe requested a review from wu-hui June 9, 2023 22:50
@wu-hui wu-hui merged commit b63708a into main Jun 20, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 20, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 20, 2023
@dconeybe dconeybe deleted the dconeybe/FirestoreIntegrationTestAndroidExceptionHelpers branch June 21, 2023 17:13
@firebase firebase locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels
api: firestore skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @wu-hui