-
Notifications
You must be signed in to change notification settings - Fork 123
Update FirestoreCache key type #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
41a85e1
debugging the memory error
milaGGL 7a6bbc2
change the firestore cache map key type
milaGGL 7bf521a
fill in default database id
milaGGL 6c46314
remove std::cout
milaGGL 81d607e
format
milaGGL 258253e
Update validation_test.cc
milaGGL dba9351
remove getInstance success check
milaGGL bdf4a1c
update test firestore create function
milaGGL 59e0710
Skip the integration test
milaGGL 6433b90
format
milaGGL 51f8bec
test firestore terminate() function
milaGGL 86cced1
change database_id reference to value
milaGGL b19d9a6
Apply suggestions from code review
milaGGL f5370f1
test against emulator
milaGGL 63a7f7c
format
milaGGL 4632ea0
enrich integration test cases
milaGGL 3bde518
add terminate default db test case
milaGGL d549147
Use test helper to run tests on emulator
milaGGL 1ca16a1
format
milaGGL aad6845
add <utility> as required by lint
milaGGL 8ee1871
resolve comments
milaGGL 3d7b986
resolve comments
milaGGL d53fbc7
remove Integration_Test friend from firestore_main.h
milaGGL 6f7d3ea
remove `reset()`s
milaGGL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.