-
Notifications
You must be signed in to change notification settings - Fork 124
[macOS sandbox mode] Application group name mangling for semaphores #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally approved, but I had a few comments - it would be okay to address some in a followup.
jonsimantov
reviewed
Dec 20, 2022
jonsimantov
approved these changes
Dec 21, 2022
❌ Integration test FAILEDRequested by @DellaBitta on commit 3095517
Add flaky tests to go/fpl-cpp-flake-tracker |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When macOS Sandbox mode is enabled, macOS requires that semaphores have a name that is prefixed by the App's Group Name. If the semaphore's name doesn't match this convention then its creation fails.
Unfortunately there's no official way for the SDK to query the app's group name at runtime, so we can't automatically mangle the semaphore names.
Instead I've updated the SDK to use an
Info.plist
property namedFBAppGroupEntitlementName
on macOS. If that property is present then the SDK will use it's value to prefix the semaphore names.As an additional issue, the SDK attempted to detect semaphore creation errors by comparing the semaphore handle to
nil
. But in the case of macOS, a semaphore creation error returnsSEM_FAILED
which is0xFFFFFFFFFFFFFFFF
, notnil
. And on Linux,sem_init
returns-1
. I've updated the corresponding platform implementations to detect the correct values for these errors.Testing
Integration Test
Packaging -> Integration Test
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.