Skip to content

Update Android dependencies - Wed Jul 27 2022 #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

firebase-workflow-trigger[bot]
Copy link
Contributor

Triggered by firebase-android-sdk Jul 27 release.

Android

  • com.google.firebase.firebase_bom → 30.3.1

Created by Update Android and iOS dependencies workflow.

[Triggered](https://github.com/firebase/firebase-android-sdk/actions/runs/2748684820) by [firebase-android-sdk Jul 27 release](firebase/firebase-android-sdk@0fe063e).

  ### Android

- com.google.firebase.firebase_bom → 30.3.1

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/2748690687).
@firebase-workflow-trigger firebase-workflow-trigger bot added the tests-requested: quick Trigger a quick set of integration tests. label Jul 27, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 27, 2022
@github-actions
Copy link

github-actions bot commented Jul 27, 2022

❌  Integration test FAILED

Requested by @jonsimantov on commit 33554c8
Last updated: Mon Aug 8 14:27 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FAILURE] [tvOS] [macos] [tvos_simulator]
(1 failed tests)  CleanupTest.DocumentChangeIsBlankAfterCleanup
storage [BUILD] [ERROR] [Windows] [x64] [openssl]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 27, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 27, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 27, 2022
@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Jul 27, 2022
@jonsimantov jonsimantov requested a review from DellaBitta July 29, 2022 17:47
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern is the AdMob version bump. Are we sure we want to bring in dependencies to a deprecated API that's not well tested?

@jonsimantov
Copy link
Contributor

Only concern is the AdMob version bump. Are we sure we want to bring in dependencies to a deprecated API that's not well tested?

What AdMob version bump?

@DellaBitta
Copy link
Contributor

DellaBitta commented Aug 8, 2022

I have no idea what I was referring to.

Everything LGTM.

@jonsimantov jonsimantov merged commit 33554c8 into main Aug 8, 2022
@jonsimantov jonsimantov deleted the workflow/auto-update-deps-121-20220727-180721 branch August 8, 2022 18:15
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 8, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 8, 2022
@firebase firebase locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants