Skip to content

Commit e5a4993

Browse files
authored
See if setting core.eol git config to lf fixes windows build errors.
1 parent 4c8b470 commit e5a4993

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

.github/workflows/android.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,11 @@ jobs:
6262
git config --global credential.helper 'store --file /tmp/git-credentials'
6363
echo 'https://${{ github.token }}@github.com' > /tmp/git-credentials
6464
65-
- name: Enable Git Long-paths Support
65+
- name: Enable Git Long-paths Support and LF line endings
6666
if: runner.os == 'Windows'
67-
run: git config --system core.longpaths true
67+
run: |
68+
git config --system core.longpaths true
69+
git config --global core.eol lf
6870
6971
- name: Check expanded matrix config
7072
if: github.event.inputs.expanded_matrix == '1'

.github/workflows/desktop.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,11 @@ jobs:
102102
git config --global credential.helper 'store --file /tmp/git-credentials'
103103
echo 'https://${{ github.token }}@github.com' > /tmp/git-credentials
104104
105-
- name: Enable Git Long-paths Support
105+
- name: Enable Git Long-paths Support and LF line endings
106106
if: runner.os == 'Windows'
107-
run: git config --system core.longpaths true
107+
run: |
108+
git config --system core.longpaths true
109+
git config --global core.eol lf
108110
109111
- name: Setup Xcode version (macos)
110112
if: runner.os == 'macOS'

scripts/gha/install_test_workflow_prereqs.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ echo 'https://${GITHUB_TOKEN}@github.com' > /tmp/git-credentials
5252

5353
if [[ "${OS}" == "Windows" ]]; then
5454
git config --system core.longpaths true
55+
git config --global core.eol lf
5556
fi
5657

5758
if [[ "${OS}" == "Mac" ]]; then

0 commit comments

Comments
 (0)