Skip to content

Commit 4c8b470

Browse files
committed
update comment
1 parent 6c00fb0 commit 4c8b470

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/integration_tests.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -184,17 +184,17 @@ jobs:
184184
# To feed input into the job matrix, we first need to convert to a JSON
185185
# list. Then we can use fromJson to define the field in the matrix for the tests job.
186186
if [[ "${{ github.event.schedule }}" == "0 9 * * *" ]]; then
187-
# at 1am PST/2am PDT. Running integration tests and generate test report for all testapps except firestore
187+
# at 1am PST / 2am PDT. Run integration tests and generate test report for all testapps except firestore
188188
apis="admob,analytics,auth,database,dynamic_links,functions,gma,installations,messaging,remote_config,storage"
189189
elif [[ "${{ github.event.schedule }}" == "0 10 * * *" || "${{ github.event.schedule }}" == "0 11 * * *" ]]; then
190-
# at 2am PST/3am PDT and 3am PST/4am PDT. Running integration tests for firestore and generate test report.
190+
# at 2am PST / 3am PDT and 3am PST / 4am PDT. Run integration tests for firestore and generate test report.
191191
apis="firestore"
192192
else
193193
apis=$( python scripts/gha/print_matrix_configuration.py -c -w integration_tests -k apis -o "${{github.event.inputs.apis}}" ${TEST_MATRIX_PARAM} )
194194
fi
195195
if [[ "${{ github.event.schedule }}" == "0 11 * * *" ]]; then
196-
# at 3am PST/4am PDT. Running firestore desktop integration test aginst tip-of-tree ios repo
197-
matrix_platform="Desktop"
196+
# at 3am PST / 4am PDT. Run firestore desktop integration test aginst tip-of-tree ios repo
197+
matrix_platform=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k platform -o "Desktop" --apis ${apis} )
198198
matrix_os=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k os -o "ubuntu-20.04,macos-12")
199199
else
200200
matrix_platform=$( python scripts/gha/print_matrix_configuration.py -w integration_tests ${TEST_MATRIX_PARAM} -k platform -o "${{github.event.inputs.platforms}}" --apis ${apis} )
@@ -328,7 +328,7 @@ jobs:
328328
fi
329329
fi
330330
if [[ "${{ github.event.schedule }}" == "0 11 * * *" ]]; then
331-
# at 3am PST/4am PDT. Running firestore desktop integration test aginst tip-of-tree ios repo
331+
# at 3am PST / 4am PDT. Run firestore desktop integration test aginst tip-of-tree ios repo
332332
additional_flags+=(--cmake_flag=-DFIRESTORE_DEP_SOURCE=TIP)
333333
fi
334334
python scripts/gha/build_testapps.py --p Desktop \
@@ -1375,7 +1375,7 @@ jobs:
13751375
additional_flags=(--build_against sdk)
13761376
else
13771377
if [[ "${{ github.event.schedule }}" == "0 11 * * *" ]]; then
1378-
# at 3am PST/4am PDT. Running firestore desktop integration test aginst tip-of-tree ios repo
1378+
# at 3am PST / 4am PDT. Run firestore desktop integration test aginst tip-of-tree ios repo
13791379
additional_flags=(--build_against tip)
13801380
else
13811381
additional_flags=(--build_against repo)

0 commit comments

Comments
 (0)