Skip to content

Change FIAM window manager visibility check #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2019
Merged

Change FIAM window manager visibility check #941

merged 2 commits into from
Oct 24, 2019

Conversation

JasonAHeron
Copy link
Contributor

Attempt to fix #379 by changing window visibility check

@googlebot googlebot added the cla: yes Override cla label Oct 24, 2019
@JasonAHeron JasonAHeron requested a review from MeghaB October 24, 2019 19:00
MeghaB
MeghaB approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@MeghaB MeghaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@JasonAHeron JasonAHeron merged commit 363dd57 into master Oct 24, 2019
@JasonAHeron JasonAHeron deleted the window_manager_please branch October 24, 2019 22:35
msasikanth pushed a commit to msasikanth/firebase-android-sdk that referenced this pull request Nov 19, 2019
@JasonAHeron @msasikanth
Change FIAM window manager visibility check (firebase#941)
4f7dece 
* change window manager visibility check
@firebase firebase locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MeghaB MeghaB MeghaB approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firebase in-appmessaging throws exception onPause()
4 participants
@JasonAHeron @MeghaB @googlebot @google-oss-bot