Fix Android connectivity issues

[thebrianchen]

Fixes b/141865469.

• Moves the responsibility to retry the connection attempt from the onClose() handler to start().

Updated (11/12):

• Use CONNECTIVITY_ATTEMPT_TIMEOUT and ONLINE_STATE_TIMEOUT to track transition vs. retry attempts.

[thebrianchen]

/retest

[thebrianchen]

/test check-changed

[thebrianchen]

/test smoke-tests

[wilhuff]

Previously, in the case of an online state timeout we performed the following things:

                logClientOfflineWarningIfNecessary(	
                    String.format(	
                        Locale.ENGLISH,	
                        "Backend didn't respond within %d seconds\n",	
                        ONLINE_STATE_TIMEOUT_MS / 1000));	
                setAndBroadcastState(OnlineState.OFFLINE);	

This isn't calling handleWatchStreamFailure so how is the OnlineState supposed to get to OFFLINE after the first timeout?

[thebrianchen]

handleWatchStreamFailure is still being called:

1. attemptReconnect() results in calling AbstractStream.close()
2. close() calls the onClose() listener passed in, which calls RemoteStore.handleWatchStreamClose()
3. handleWatchStreamClose() calls handleWatchStreamFailure().

The problem I was running into by leaving a handleWatchStreamFailure() in the timeout logic was that handleWatchStreamFailure() would be called twice, once in the timer timeout, and once in handleWatchStreamClose(). Calling attemptReconnect() would call handleWatchStreamFailure() followed by a call to startWatchStream(). The subsequent call to handleWatchStreamFailure() in the timeout logic would then clear the connectivity timer set by attemptReconnect().

[thebrianchen]

/retest

[thebrianchen]

/test smoke-tests

[thebrianchen]

/test smoke-tests

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.