Skip to content

Starting the Mutation Queue in a Transaction #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Starting the Mutation Queue in a Transaction #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions firebase-firestore/src/main/java/com/google/firebase/firestore/local/LocalStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,15 @@ public LocalStore(Persistence persistence, User initialUser) {
}

public void start() {
mutationQueue.start();
startMutationQueue();
}

private void startMutationQueue() {
persistence.runTransaction(
"Start MutationQueue",
() -> {
mutationQueue.start();
});
}

// PORTING NOTE: no shutdown for LocalStore or persistence components on Android.
Expand All @@ -148,7 +156,7 @@ public ImmutableSortedMap<DocumentKey, MaybeDocument> handleUserChange(User user
List<MutationBatch> oldBatches = mutationQueue.getAllMutationBatches();

mutationQueue = persistence.getMutationQueue(user);
mutationQueue.start();
startMutationQueue();

List<MutationBatch> newBatches = mutationQueue.getAllMutationBatches();

Expand Down