Update android gradle plugin to 3.6.2 and gradle to 5.6.4 #892

rlazo · 2019-10-09T21:57:22Z

No description provided.

rlazo · 2019-10-10T02:58:43Z

/test check-changed

rlazo · 2019-10-10T17:13:52Z

/test new-smoke-tests

rlazo · 2019-10-10T17:14:02Z

/test device-check-changed

rlazo · 2019-10-10T17:33:47Z

/test new-smoke-tests

rlazo · 2019-10-10T17:52:51Z

/test new-smoke-tests

rlazo · 2019-10-11T03:44:35Z

/test new-smoke-tests

rlazo · 2019-10-11T04:21:22Z

/test new-smoke-test

rlazo · 2019-10-11T16:48:11Z

/test new-smoke-tests

vkryachko

testing

rlazo · 2019-10-29T21:55:47Z

/test smoke-tests

rlazo · 2019-11-27T17:22:30Z

/test smoke-tests

codecov · 2020-02-05T22:07:17Z

Codecov Report

Merging #892 into master will increase coverage by 25.41%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master     #892       +/-   ##
=============================================
+ Coverage     29.22%   54.63%   +25.41%     
- Complexity      737     6368     +5631     
=============================================
  Files           203      698      +495     
  Lines          8333    33382    +25049     
  Branches        787     4526     +3739     
=============================================
+ Hits           2435    18239    +15804     
- Misses         5714    13683     +7969     
- Partials        184     1460     +1276

Flag	Coverage Δ	Complexity Δ
#Encoders_FirebaseEncodersJson	`95.93% <ø> (ø)`	`68.00 <ø> (ø)`
#Encoders_FirebaseEncodersProcessor	`100.00% <ø> (?)`	`0.00 <ø> (?)`
#Encoders_FirebaseEncodersReflective	`73.97% <ø> (ø)`	`20.00 <ø> (ø)`
#FirebaseAbt	`80.21% <ø> (?)`	`47.00 <ø> (?)`
#FirebaseCommon	`49.76% <ø> (?)`	`63.00 <ø> (?)`
#FirebaseCommon_DataCollectionTests	`100.00% <ø> (?)`	`0.00 <ø> (?)`
#FirebaseCommon_Ktx	`100.00% <ø> (?)`	`0.00 <ø> (?)`
#FirebaseComponents	`87.44% <ø> (?)`	`145.00 <ø> (?)`
#FirebaseConfig	`87.18% <ø> (?)`	`306.00 <ø> (?)`
#FirebaseConfig_Ktx	`75.00% <ø> (?)`	`0.00 <ø> (?)`
#FirebaseCrashlytics	`7.60% <ø> (+5.19%)`	`72.00 <ø> (+50.00)`
#FirebaseDatabase	`46.76% <ø> (?)`	`3270.00 <ø> (?)`
#FirebaseDatabaseCollection	`100.00% <ø> (?)`	`0.00 <ø> (?)`
#FirebaseDatabase_Ktx	`85.71% <ø> (?)`	`0.00 <ø> (?)`
#FirebaseDatatransport	`100.00% <ø> (ø)`	`3.00 <ø> (ø)`
#FirebaseDynamicLinks	`77.69% <ø> (?)`	`356.00 <ø> (?)`
#FirebaseDynamicLinks_Ktx	`100.00% <ø> (?)`	`0.00 <ø> (?)`
#FirebaseFirestore	`41.17% <ø> (?)`	`0.00 <ø> (?)`
#FirebaseFirestore_Ktx	`41.17% <ø> (?)`	`0.00 <ø> (?)`
#FirebaseFunctions	`4.55% <ø> (?)`	`4.00 <ø> (?)`
#FirebaseFunctions_Ktx	`100.00% <ø> (?)`	`0.00 <ø> (?)`
#FirebaseInappmessaging	`51.15% <ø> (-0.37%)`	`520.00 <ø> (-8.00)`
#FirebaseInappmessagingDisplay	`34.52% <ø> (ø)`	`129.00 <ø> (ø)`
#FirebaseInappmessagingDisplay_Ktx	`100.00% <ø> (ø)`	`0.00 <ø> (ø)`
#FirebaseInappmessaging_Ktx	`100.00% <ø> (ø)`	`0.00 <ø> (ø)`
#FirebaseInstallations	`58.04% <ø> (?)`	`102.00 <ø> (?)`
#FirebaseSegmentation	`52.63% <ø> (?)`	`29.00 <ø> (?)`
#FirebaseStorage	`100.00% <ø> (?)`	`0.00 <ø> (?)`
#FirebaseStorage_Ktx	`100.00% <ø> (?)`	`0.00 <ø> (?)`
#Tools_Errorprone	`100.00% <ø> (?)`	`0.00 <ø> (?)`
#Tools_Lint	`100.00% <ø> (?)`	`0.00 <ø> (?)`
#Transport_TransportBackendCct	`91.38% <ø> (ø)`	`96.00 <ø> (ø)`
#Transport_TransportRuntime	`76.71% <ø> (?)`	`439.00 <ø> (?)`

Impacted Files	Coverage Δ	Complexity Δ
...se/inappmessaging/internal/ForegroundNotifier.java	`62.96% <0.00%> (-5.04%)`	`8.00% <0.00%> (ø%)`
...le/firebase/inappmessaging/internal/ApiClient.java	`94.73% <0.00%> (-3.54%)`	`14.00% <0.00%> (+1.00%)`	⬇️
...e/inappmessaging/internal/MetricsLoggerClient.java	`87.20% <0.00%> (-2.22%)`	`26.00% <0.00%> (-4.00%)`
...ase/crashlytics/internal/common/ExecutorUtils.java	`31.57% <0.00%> (-0.86%)`	`4.00% <0.00%> (ø%)`
...se/inappmessaging/model/ProtoMarshallerClient.java	`84.61% <0.00%> (-0.34%)`	`35.00% <0.00%> (ø%)`
...m/google/firebase/crashlytics/internal/Logger.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...ogle/firebase/crashlytics/FirebaseCrashlytics.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...ogle/firebase/crashlytics/internal/Onboarding.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...irebase/crashlytics/internal/common/IdManager.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...se/crashlytics/internal/report/ReportUploader.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
... and 568 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4776b3...ba5ab3b. Read the comment docs.

codecov · 2020-02-05T22:07:39Z

Codecov Report

Merging #892 into master will decrease coverage by 19.32%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master     #892       +/-   ##
=============================================
- Coverage     54.65%   35.33%   -19.33%     
+ Complexity     6371     1712     -4659     
=============================================
  Files           698      219      -479     
  Lines         33382    12343    -21039     
  Branches       4526     1766     -2760     
=============================================
- Hits          18246     4361    -13885     
+ Misses        13678     7542     -6136     
+ Partials       1458      440     -1018

Flag	Coverage Δ	Complexity Δ
#Encoders_FirebaseEncodersJson	`?`	`?`
#Encoders_FirebaseEncodersProcessor	`?`	`?`
#Encoders_FirebaseEncodersReflective	`?`	`?`
#FirebaseAbt	`?`	`?`
#FirebaseCommon	`?`	`?`
#FirebaseCommon_DataCollectionTests	`?`	`?`
#FirebaseCommon_Ktx	`?`	`?`
#FirebaseComponents	`?`	`?`
#FirebaseConfig	`?`	`?`
#FirebaseConfig_Ktx	`?`	`?`
#FirebaseCrashlytics	`7.60% <ø> (-92.40%)`	`72.00 <ø> (+72.00)`
#FirebaseDatabase	`46.78% <ø> (-38.94%)`	`1635.00 <ø> (+1635.00)`
#FirebaseDatabaseCollection	`?`	`?`
#FirebaseDatabase_Ktx	`85.71% <ø> (ø)`	`0.00 <ø> (ø)`	⬆️
#FirebaseDatatransport	`100.00% <ø> (ø)`	`3.00 <ø> (-12.00)`	⬆️
#FirebaseDynamicLinks	`?`	`?`
#FirebaseDynamicLinks_Ktx	`?`	`?`
#FirebaseFirestore	`?`	`?`
#FirebaseFirestore_Ktx	`?`	`?`
#FirebaseFunctions	`5.31% <ø> (-0.31%)`	`2.00 <ø> (-8.00)`
#FirebaseFunctions_Ktx	`100.00% <ø> (ø)`	`0.00 <ø> (ø)`	⬆️
#FirebaseInappmessaging	`?`	`?`
#FirebaseInappmessagingDisplay	`?`	`?`
#FirebaseInappmessagingDisplay_Ktx	`?`	`?`
#FirebaseInappmessaging_Ktx	`?`	`?`
#FirebaseInstallations	`?`	`?`
#FirebaseSegmentation	`?`	`?`
#FirebaseStorage	`?`	`?`
#FirebaseStorage_Ktx	`?`	`?`
#Tools_Errorprone	`?`	`?`
#Tools_Lint	`?`	`?`
#Transport_TransportBackendCct	`?`	`?`
#Transport_TransportRuntime	`?`	`?`

Impacted Files	Coverage Δ	Complexity Δ
...rashlytics/internal/settings/CachedSettingsIo.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`	⬆️
...ebase/crashlytics/internal/network/HttpMethod.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`	⬆️
...internal/stacktrace/MiddleOutFallbackStrategy.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`	⬆️
...ics/internal/settings/SettingsV3JsonTransform.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`	⬆️
...hlytics/internal/stacktrace/MiddleOutStrategy.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`	⬆️
...ics/internal/stacktrace/RemoveRepeatsStrategy.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`	⬆️
...gle/firebase/database/core/utilities/TreeNode.java	`25.00% <0.00%> (ø)`	`1.00% <0.00%> (ø%)`	⬆️
...shlytics/internal/settings/SettingsController.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`	⬆️
...ase/crashlytics/internal/network/HttpResponse.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`	⬆️
...abase/core/view/filter/ChildChangeAccumulator.java	`61.29% <0.00%> (-12.91%)`	`11.00% <0.00%> (-1.00%)`
... and 675 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f91d7...c61d9bf. Read the comment docs.

google-oss-bot · 2020-06-18T11:26:27Z

Coverage Report

Affected SDKs

`firebase-database`

SDK overall coverage did not change between base commit (f6b788e) and head commit (ae6f482b). However there are changes in individual files.

Filename	Base (`f6b788e`)	Head (ae6f482b)	Diff
ChildChangeAccumulator.java	96.77%	83.87%	-12.90%
DoubleNode.java	88.89%	100.00%	+11.11%
QueryParams.java	89.76%	90.36%	+0.60%
ViewProcessor.java	92.05%	92.35%	+0.31%

firebase-storage

SDK overall coverage changed from 85.44% (f6b788e) to 85.48% (ae6f482b) by +0.04%.

Filename Base (f6b788e) Head (ae6f482b) Diff

UploadTask.java 79.85% 80.22% +0.37%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (ae6f482b) is created by Prow via merging commits: f6b788e ba5ab3b.

google-oss-bot · 2020-06-18T11:30:40Z

Binary Size Report

Affected SDKs

firebase-abt

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 35.0 kB ? (?)
firebase-common

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 34.3 kB ? (?)
firebase-common-ktx

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 5.66 kB ? (?)
firebase-components

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 34.4 kB ? (?)
firebase-config

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 214 kB ? (?)
firebase-config-ktx

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 5.41 kB ? (?)
firebase-crashlytics

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 409 kB ? (?)
firebase-crashlytics-ktx

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 6.65 kB ? (?)
firebase-crashlytics-ndk

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 598 kB ? (?)
firebase-database

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 481 kB ? (?)
firebase-database-collection

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 33.6 kB ? (?)
firebase-database-ktx

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 6.90 kB ? (?)
firebase-datatransport

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 4.73 kB ? (?)
firebase-decoders-json

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 7.52 kB ? (?)
firebase-dynamic-links

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 50.6 kB ? (?)
firebase-dynamic-links-ktx

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 7.39 kB ? (?)
firebase-encoders-json

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 18.1 kB ? (?)
firebase-encoders-reflective

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 7.65 kB ? (?)
firebase-firestore

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 1.07 MB ? (?)
firebase-firestore-ktx

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 6.59 kB ? (?)
firebase-functions

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 25.3 kB ? (?)
firebase-functions-ktx

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 5.34 kB ? (?)
firebase-inappmessaging

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 473 kB ? (?)
firebase-inappmessaging-display

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 163 kB ? (?)
firebase-inappmessaging-display-ktx

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 17.4 kB ? (?)
firebase-inappmessaging-ktx

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 4.87 kB ? (?)
firebase-installations

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 57.7 kB ? (?)
firebase-installations-interop

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 7.18 kB ? (?)
firebase-segmentation

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 30.8 kB ? (?)
firebase-storage

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 119 kB ? (?)
firebase-storage-ktx

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 5.66 kB ? (?)
protolite-well-known-types

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 1.20 MB ? (?)
transport-api

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 6.58 kB ? (?)
transport-backend-cct

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 43.3 kB ? (?)
transport-runtime

Type Base (f6b788e) Head (ae6f482b) Diff

aar ? 127 kB ? (?)

Test Logs

Head (ae6f482b): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/892/binary-size/1273620495299776515

Notes

Head commit (ae6f482b) is created by Prow via merging commits: f6b788e ba5ab3b.

google-oss-bot · 2020-06-18T14:36:33Z

@rlazo: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
new-smoke-tests	`ee4bf30`	link	`/test new-smoke-tests`
device-check-changed	`ba5ab3b`	link	`/test device-check-changed`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rlazo · 2020-06-18T16:04:49Z

Hey @mrwillis21 please take a look at this PR. By upgrading the android gradle plugin version we can now specify the required ndk version. Please let me know if this sgty. Thanks!

Update android gradle plugin to 3.5.1

b75403d

rlazo requested review from vkryachko and ashwinraghav October 9, 2019 21:57

googlebot added the cla: yes Override cla label Oct 9, 2019

google-oss-bot added the size/XS label Oct 9, 2019

Testing with abortOnError false on the linter

ee4bf30

google-oss-bot added size/S and removed size/XS labels Oct 11, 2019

vkryachko reviewed Oct 15, 2019

View reviewed changes

Merge branch 'master' into rl.update-android-gradle

66bbcf5

rlazo added 3 commits November 27, 2019 11:03

Merge branch 'master' into rl.update-android-gradle

8aef556

Update to 3.5.2

2f668d0

Update ALL to 3.5.2

7d2be48

rlazo changed the title ~~Update android gradle plugin to 3.5.1~~ Update android gradle plugin to 3.5.2 Nov 27, 2019

rlazo added 3 commits November 28, 2019 22:07

test

2facb5c

Revert test change.

6195e81

Merge branch 'master' into rl.update-android-gradle

c61d9bf

Merge branch 'master' into rl.update-android-gradle

85f129e

Update patch.

f23d498

google-oss-bot added size/XS and removed size/S labels Jun 18, 2020

Bump versions.

ce7d217

rlazo changed the title ~~Update android gradle plugin to 3.5.2~~ Update android gradle plugin to 3.5.3 Jun 18, 2020

rlazo added 3 commits June 18, 2020 07:32

Don't upgrade smoke-tests.

67ec34c

Upgrade gradle version.

2b4a21b

Update to 3.6.2

fa50f6d

google-oss-bot added size/M and removed size/XS labels Jun 18, 2020

Require the right ndk version in gradle file.

ba5ab3b

rlazo changed the title ~~Update android gradle plugin to 3.5.3~~ Update android gradle plugin to 3.6.2 and gradle to 5.6.4 Jun 18, 2020

rlazo requested review from vkryachko and mrwillis21 June 18, 2020 15:21

vkryachko approved these changes Jun 18, 2020

View reviewed changes

mrwillis21 approved these changes Jun 18, 2020

View reviewed changes

rlazo merged commit a7096ac into master Jun 18, 2020

rlazo deleted the rl.update-android-gradle branch June 18, 2020 19:39

firebase locked and limited conversation to collaborators Jul 19, 2020

Update android gradle plugin to 3.6.2 and gradle to 5.6.4 #892

Update android gradle plugin to 3.6.2 and gradle to 5.6.4 #892

Uh oh!

Conversation

rlazo commented Oct 9, 2019

Uh oh!

rlazo commented Oct 10, 2019

Uh oh!

rlazo commented Oct 10, 2019

Uh oh!

rlazo commented Oct 10, 2019

Uh oh!

rlazo commented Oct 10, 2019

Uh oh!

rlazo commented Oct 10, 2019

Uh oh!

rlazo commented Oct 11, 2019

Uh oh!

rlazo commented Oct 11, 2019

Uh oh!

rlazo commented Oct 11, 2019

Uh oh!

vkryachko left a comment

Choose a reason for hiding this comment

Uh oh!

rlazo commented Oct 29, 2019

Uh oh!

rlazo commented Nov 27, 2019

Uh oh!

codecov bot commented Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov bot commented Feb 5, 2020

Codecov Report

Uh oh!

google-oss-bot commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Affected SDKs

firebase-database

firebase-storage

Test Logs

Notes

Uh oh!

google-oss-bot commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

firebase-abt

firebase-common

firebase-common-ktx

firebase-components

firebase-config

firebase-config-ktx

firebase-crashlytics

firebase-crashlytics-ktx

firebase-crashlytics-ndk

firebase-database

firebase-database-collection

firebase-database-ktx

firebase-datatransport

firebase-decoders-json

firebase-dynamic-links

firebase-dynamic-links-ktx

firebase-encoders-json

firebase-encoders-reflective

firebase-firestore

firebase-firestore-ktx

firebase-functions

firebase-functions-ktx

firebase-inappmessaging

firebase-inappmessaging-display

firebase-inappmessaging-display-ktx

firebase-inappmessaging-ktx

firebase-installations

firebase-installations-interop

firebase-segmentation

firebase-storage

firebase-storage-ktx

codecov bot commented Feb 5, 2020 •

edited

Loading

google-oss-bot commented Jun 18, 2020 •

edited

Loading

`firebase-database`

`firebase-storage`

google-oss-bot commented Jun 18, 2020 •

edited

Loading

`firebase-abt`

`firebase-common`

`firebase-common-ktx`

`firebase-components`

`firebase-config`

`firebase-config-ktx`

`firebase-crashlytics`

`firebase-crashlytics-ktx`

`firebase-crashlytics-ndk`

`firebase-database`

`firebase-database-collection`

`firebase-database-ktx`

`firebase-datatransport`

`firebase-decoders-json`

`firebase-dynamic-links`

`firebase-dynamic-links-ktx`

`firebase-encoders-json`

`firebase-encoders-reflective`

`firebase-firestore`

`firebase-firestore-ktx`

`firebase-functions`

`firebase-functions-ktx`

`firebase-inappmessaging`

`firebase-inappmessaging-display`

`firebase-inappmessaging-display-ktx`

`firebase-inappmessaging-ktx`

`firebase-installations`

`firebase-installations-interop`

`firebase-segmentation`

`firebase-storage`

`firebase-storage-ktx`

`protolite-well-known-types`

`transport-api`

`transport-backend-cct`

`transport-runtime`