Port structural changes from Multi-Tab #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt-multitab
branch
from
6cbe2c9 to
8f6c8cc
Compare
mikelehen
suggested changes
Oct 24, 2018
| viewChanges, | ||
| fromCache, | ||
| mutatedKeys, | ||
| true); |
There was a problem hiding this comment.
Note that this changed the unit tests quite a bit, as Web doesn't verify the excludeMetadataChanges flag. Time for a backport.
|
btw, if you merge the latest master there should be a slightly higher chance CI will pass. |
schmidt-sebastian
force-pushed
the
mrschmidt-multitab
branch
from
37ad13d to
ed71aff
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-multitab
branch
from
ed71aff to
56ea93a
Compare
|
/test connected-check |
|
@schmidt-sebastian: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
mikelehen
approved these changes
Oct 26, 2018
|
/test connected-check |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a port of the structural changes from the Multi-Tab PR (firebase/firebase-js-sdk#1000)
It's might be worth discussing just getting rid of the TargetIdGenerator at this point...