Skip to content

Enabling FIS network call timeout. #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Enabling FIS network call timeout. #827

merged 2 commits into from
Sep 19, 2019

Conversation

ankitaj224
Copy link
Contributor

@ankitaj224 ankitaj224 commented Sep 19, 2019

There is no timeout for HttpsURLConnection. Rayo mentioned other FIS SDKs timeout after 10s.

@googlebot googlebot added the cla: yes Override cla label Sep 19, 2019
@@ -90,6 +92,8 @@ public InstallationResponse createFirebaseInstallation(
apiKey));

HttpsURLConnection httpsURLConnection = (HttpsURLConnection) url.openConnection();
httpsURLConnection.setConnectTimeout(TIMEOUT_IN_MILLI_SECS);
httpsURLConnection.setReadTimeout(TIMEOUT_IN_MILLI_SECS);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to verify if this is the right approach. I will then add it to all the network calls.

@ankitaj224 ankitaj224 merged commit ac24fae into fis_sdk Sep 19, 2019
@ankitaj224 ankitaj224 deleted the pending_timeout branch September 19, 2019 21:28
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants