Skip to content

FID delete() implementation. #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2019
Merged

FID delete() implementation. #813

merged 3 commits into from
Sep 18, 2019

Conversation

ankitaj224
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Sep 17, 2019
ciarand
ciarand reviewed Sep 17, 2019
View reviewed changes
@ankitaj224 ankitaj224 requested a review from ciarand September 17, 2019 21:51
@ankitaj224
Copy link
Contributor Author

/test new-smoke-tests

@ankitaj224 ankitaj224 merged commit 5b0acbf into fis_sdk Sep 18, 2019
@ankitaj224 ankitaj224 deleted the fis_delete branch September 18, 2019 18:30
@firebase firebase locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ciarand ciarand ciarand approved these changes

@andirayo andirayo Awaiting requested review from andirayo

@diwu-arete diwu-arete Awaiting requested review from diwu-arete

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankitaj224 @ciarand @googlebot @google-oss-bot