Allow passing POJOs as field values throughout API. #76
Conversation
All of our parsing code now accepts POJOs meaning you can pass them: * As values in a Map<> passed to set(). * As values to a update() call. * As elements in an array transform operation. * As values in query field filters. Also removed set(Map<>) overloads since they are now redundant with set(Object).
| reason = "Could not serialize object. " + reason; | ||
| if (path.getLength() > 0) { | ||
| reason = reason + " (found in field '" + path.toString() + "')"; | ||
| } | ||
| return new RuntimeException(reason); | ||
| return new IllegalArgumentException(reason); |
There was a problem hiding this comment.
Some errors (in particular trying to use an Array instead of a List) are now getting caught in the POJO mapper instead of our UserDataConverter. To keep the exception type consistent, I CustomClassMapper to throw IllegalArgumentExceptions (which is more correct anyway).
| @@ -411,7 +411,7 @@ public void testArraysFail() { | |||
| wrap(array); | |||
| fail("wrap should have failed"); | |||
| } catch (IllegalArgumentException e) { | |||
| assertNotEquals(-1, e.getMessage().indexOf("use a List instead")); | |||
| assertNotEquals(-1, e.getMessage().indexOf("use Lists instead")); | |||
There was a problem hiding this comment.
This error is now coming from CustomClassMapper and so the wording changed slightly.
| // Convert POJOs | ||
| Object converted = CustomClassMapper.convertToPlainJavaTypes(input); | ||
|
|
||
| if (source == UserData.Source.Set && !(converted instanceof Map)) { |
There was a problem hiding this comment.
How excited do you feel about moving this assert (and maybe the if-check in 203) to parseMergeData and parseSetData?
There was a problem hiding this comment.
I made a convertAndParseDocumentData() helper instead. Does that work? This added 3 lines, but I found some test comments to fix up which ended up removing 7 lines, so we're okay.
|
/retest |
firebase-firestore/src/main/java/com/google/firebase/firestore/UserDataConverter.java
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/UserDataConverter.java
Outdated
Show resolved
Hide resolved
|
/test smoke-tests-debug |
|
/test smoke-tests-debug |
|
/test smoke-tests-debug |
|
/retest |
* Added `T get(..., Class<T>, ...)` overloads for extracting fields as a custom class (POJO) type.
|
/retest |
|
/test connected-check |
All of our parsing code now accepts POJOs meaning you can pass them:
Also removed set(Map<>) overloads since they are now redundant with set(Object).