Skip to content

Revert "Remove overrideChannelBuilder" #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2019
Merged

Revert "Remove overrideChannelBuilder" #756

merged 2 commits into from
Aug 30, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

Reverts the part of #678 that is still used in Google3.

@googlebot googlebot added the cla: yes Override cla label Aug 30, 2019
wilhuff
wilhuff approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Aug 30, 2019
@schmidt-sebastian schmidt-sebastian merged commit 534e5b3 into master Aug 30, 2019
@rlazo rlazo deleted the revert-678-mrschmidt/overrideChannelBuilder branch September 27, 2019 14:55
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @wilhuff @googlebot @google-oss-bot