Index-Free: Only exclude limit queries if last document changed #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
approved these changes
Aug 27, 2019
| // limit. If the last document was edited after the query was last synchronized, there is a | ||
| // chance that another document from cache sorts higher, in which case we have to perform a full | ||
| // cache scan. | ||
| Comparator<Document> comparator = query.comparator(); |
There was a problem hiding this comment.
This comment doesn't really explain why only the last document matters and it took me a while to reason it through.
Maybe add a paragraph explaining why changes to documents that are not the last document don't matter?
There was a problem hiding this comment.
Done. Can you take another look?
schmidt-sebastian
force-pushed
the
mrschmidt/indexfree-order
branch
from
2861847 to
d583283
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/indexfree-order
branch
from
d21d094 to
6dd7e82
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of not using Index-Free queries for all limit queries with modified documents, we can take advantage of the fact that documents edit that don't affect the boundary (last document) don't cause other documents from cache to suddenly fall into the limit.