Index-free: Use different SQL for non-index free queries #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Very clever and it happens to be a portable approach as well. I like it a lot. That @mikelehen is pretty sharp.
|
LOL... I just didn't want to have to finish reviewing the migration code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I blame this one on @mikelehen
The basic thought process behind is that we don't need to backfill any read times. When a user upgrades, none of the QueryData will have a lastLimboFreeSnapshot version set. Once we have a lastLimboFreeSnapshot, we know that the target mapping can be relied upon. Any changes since the target mapping will have a read time.
Thoughts? Fears?