fix more strict mode violation #6937

themiswang · 2025-05-05T17:38:38Z

#no-changelog

github-actions · 2025-05-05T17:38:47Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

github-actions · 2025-05-05T17:38:55Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v11.1

google-oss-bot · 2025-05-05T17:43:47Z

Coverage Report ¹

Affected Products

No changes between base commit (0a880cc) and merge commit (d0ed7ec).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/bLn7VwTn4Y.html

google-oss-bot · 2025-05-05T17:54:35Z

Size Report ¹

Affected Products

firebase-crashlytics
Type Base (0a880cc) Merge (d0ed7ec) Diff
aar 415 kB 416 kB +167 B (+0.0%)
apk (aggressive) 785 kB 785 kB +132 B (+0.0%)
apk (release) 6.65 MB 6.65 MB +132 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/jYiqIZ8o2f.html

github-actions · 2025-05-05T17:55:12Z

Test Results

8 files - 14 8 suites - 14 20s ⏱️ -14s
22 tests - 78 22 ✅ - 78 0 💤 ±0 0 ❌ ±0
44 runs - 156 44 ✅ - 156 0 💤 ±0 0 ❌ ±0

Results for commit 6a3ccbc. ± Comparison against base commit 0a880cc.

This pull request removes 100 and adds 22 tests. Note that renamed tests count towards both.

com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ image rejected
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ long reply
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ prompt blocked for safety
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ short reply
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ stopped for recitation
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ citation returns correctly
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ invalid api key
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ long reply
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ response blocked for safety
…

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…

google-oss-bot · 2025-05-05T18:08:20Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (0a880cc) and the CI merge commit (d0ed7ec)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 0a880cc: https://storage.googleapis.com/firebase-sdk-metric-reports/wWX0ybmViC/index.html
- d0ed7ec: https://storage.googleapis.com/firebase-sdk-metric-reports/c2VVDUHyLr/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`0a880cc`	`d0ed7ec`	Diff	Significant (?)
p10	9.19 ±2 ms	8.32 ±0.5 ms	-868 μs (-9.4%)	NO
p25	9.77 ±2 ms	8.85 ±0.5 ms	-916 μs (-9.4%)	NO
p50	10.7 ±2 ms	9.66 ±0.6 ms	-1.01 ms (-9.5%)	NO
p75	11.8 ±2 ms	10.6 ±0.7 ms	-1.16 ms (-9.9%)	NO
p90	13.1 ±2 ms	11.9 ±0.8 ms	-1.13 ms (-8.7%)	NO

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`d0ed7ec`	2025-05-05_17:56:12.430085_aoAo 2025-05-05_17:56:12.430125_jPOl 2025-05-05_17:56:12.430137_aSlz 2025-05-05_17:56:12.430145_afyx 2025-05-05_17:56:12.430151_QLEe 2025-05-05_17:56:12.430159_LLVy 2025-05-05_17:56:12.430171_XXYY 2025-05-05_17:56:12.430177_WFth 2025-05-05_17:56:12.430184_hLxt 2025-05-05_17:56:12.430190_PISy

redfin-30

Percentile	`0a880cc`	`d0ed7ec`	Diff	Significant (?)
p10	11.1 ±2 ms	11.3 ±4 ms	+264 μs (+2.4%)	NO
p25	11.7 ±2 ms	11.9 ±5 ms	+208 μs (+1.8%)	NO
p50	12.7 ±3 ms	12.8 ±6 ms	+141 μs (+1.1%)	NO
p75	14.0 ±4 ms	14.0 ±7 ms	+57.3 μs (+0.4%)	NO
p90	15.9 ±5 ms	15.8 ±7 ms	-139 μs (-0.9%)	NO

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`d0ed7ec`	2025-05-05_17:56:12.430085_aoAo 2025-05-05_17:56:12.430125_jPOl 2025-05-05_17:56:12.430137_aSlz 2025-05-05_17:56:12.430145_afyx 2025-05-05_17:56:12.430151_QLEe 2025-05-05_17:56:12.430159_LLVy 2025-05-05_17:56:12.430171_XXYY 2025-05-05_17:56:12.430177_WFth 2025-05-05_17:56:12.430184_hLxt 2025-05-05_17:56:12.430190_PISy

`fire-rc`

Device Statistics Distributions

oriole-32

Percentile	`0a880cc`	`d0ed7ec`	Diff	Significant (?)
p10	473 ±756 μs	476 ±743 μs	+3.41 μs (+0.7%)	NO
p25	504 ±805 μs	499 ±769 μs	-5.14 μs (-1.0%)	NO
p50	556 ±882 μs	548 ±835 μs	-7.16 μs (-1.3%)	NO
p75	638 ±989 μs	654 ±968 μs	+15.6 μs (+2.5%)	NO
p90	790 ±1227 μs	821 ±1192 μs	+30.9 μs (+3.9%)	NO

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`d0ed7ec`	2025-05-05_17:56:12.430085_aoAo 2025-05-05_17:56:12.430125_jPOl 2025-05-05_17:56:12.430137_aSlz 2025-05-05_17:56:12.430145_afyx 2025-05-05_17:56:12.430151_QLEe 2025-05-05_17:56:12.430159_LLVy 2025-05-05_17:56:12.430171_XXYY 2025-05-05_17:56:12.430177_WFth 2025-05-05_17:56:12.430184_hLxt 2025-05-05_17:56:12.430190_PISy

redfin-30

Percentile	`0a880cc`	`d0ed7ec`	Diff	Significant (?)
p10	477 ±552 μs	167 ±80 μs	-310 μs (-65.1%)	NO
p25	536 ±639 μs	178 ±91 μs	-358 μs (-66.7%)	NO
p50	627 ±768 μs	199 ±116 μs	-428 μs (-68.3%)	NO
p75	783 ±961 μs	248 ±191 μs	-535 μs (-68.4%)	NO
p90	1.04 ±1 ms	338 ±325 μs	-699 μs (-67.4%)	NO

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`d0ed7ec`	2025-05-05_17:56:12.430085_aoAo 2025-05-05_17:56:12.430125_jPOl 2025-05-05_17:56:12.430137_aSlz 2025-05-05_17:56:12.430145_afyx 2025-05-05_17:56:12.430151_QLEe 2025-05-05_17:56:12.430159_LLVy 2025-05-05_17:56:12.430171_XXYY 2025-05-05_17:56:12.430177_WFth 2025-05-05_17:56:12.430184_hLxt 2025-05-05_17:56:12.430190_PISy

`fire-sessions`

Device Statistics Distributions

oriole-32

Percentile	`0a880cc`	`d0ed7ec`	Diff	Significant (?)
p10	2.48 ±1 ms	1.97 ±0.5 ms	-506 μs (-20.4%)	NO
p25	2.68 ±1 ms	2.11 ±0.5 ms	-563 μs (-21.0%)	NO
p50	2.99 ±1 ms	2.43 ±0.5 ms	-561 μs (-18.7%)	NO
p75	3.55 ±1 ms	2.98 ±0.6 ms	-575 μs (-16.2%)	NO
p90	4.26 ±1 ms	3.90 ±0.6 ms	-355 μs (-8.3%)	NO

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`d0ed7ec`	2025-05-05_17:56:12.430085_aoAo 2025-05-05_17:56:12.430125_jPOl 2025-05-05_17:56:12.430137_aSlz 2025-05-05_17:56:12.430145_afyx 2025-05-05_17:56:12.430151_QLEe 2025-05-05_17:56:12.430159_LLVy 2025-05-05_17:56:12.430171_XXYY 2025-05-05_17:56:12.430177_WFth 2025-05-05_17:56:12.430184_hLxt 2025-05-05_17:56:12.430190_PISy

redfin-30

Percentile	`0a880cc`	`d0ed7ec`	Diff	Significant (?)
p10	4.56 ±1 ms	4.37 ±1 ms	-198 μs (-4.3%)	NO
p25	5.02 ±1 ms	4.74 ±1 ms	-273 μs (-5.5%)	NO
p50	5.73 ±2 ms	5.46 ±2 ms	-269 μs (-4.7%)	NO
p75	6.64 ±3 ms	6.34 ±4 ms	-301 μs (-4.5%)	NO
p90	7.63 ±4 ms	7.08 ±4 ms	-551 μs (-7.2%)	NO

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`d0ed7ec`	2025-05-05_17:56:12.430085_aoAo 2025-05-05_17:56:12.430125_jPOl 2025-05-05_17:56:12.430137_aSlz 2025-05-05_17:56:12.430145_afyx 2025-05-05_17:56:12.430151_QLEe 2025-05-05_17:56:12.430159_LLVy 2025-05-05_17:56:12.430171_XXYY 2025-05-05_17:56:12.430177_WFth 2025-05-05_17:56:12.430184_hLxt 2025-05-05_17:56:12.430190_PISy

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`0a880cc`	`d0ed7ec`	Diff	Significant (?)
p10	193 ±2 ms	201 ±5 ms	+7.69 ms (+4.0%)	NO
p25	199 ±2 ms	206 ±5 ms	+7.49 ms (+3.8%)	NO
p50	205 ±2 ms	213 ±4 ms	+8.09 ms (+3.9%)	NO
p75	213 ±3 ms	221 ±5 ms	+8.40 ms (+3.9%)	NO
p90	221 ±3 ms	231 ±6 ms	+9.89 ms (+4.5%)	NO

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`d0ed7ec`	2025-05-05_17:56:12.430085_aoAo 2025-05-05_17:56:12.430125_jPOl 2025-05-05_17:56:12.430137_aSlz 2025-05-05_17:56:12.430145_afyx 2025-05-05_17:56:12.430151_QLEe 2025-05-05_17:56:12.430159_LLVy 2025-05-05_17:56:12.430171_XXYY 2025-05-05_17:56:12.430177_WFth 2025-05-05_17:56:12.430184_hLxt 2025-05-05_17:56:12.430190_PISy

redfin-30

Percentile	`0a880cc`	`d0ed7ec`	Diff	Significant (?)
p10	225 ±4 ms	250 ±4 ms	+24.5 ms (+10.9%)	YES
p25	231 ±4 ms	256 ±4 ms	+25.6 ms (+11.1%)	YES
p50	239 ±5 ms	263 ±3 ms	+24.4 ms (+10.2%)	YES
p75	247 ±5 ms	272 ±4 ms	+24.9 ms (+10.1%)	YES
p90	255 ±5 ms	283 ±6 ms	+27.7 ms (+10.8%)	YES

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`d0ed7ec`	2025-05-05_17:56:12.430085_aoAo 2025-05-05_17:56:12.430125_jPOl 2025-05-05_17:56:12.430137_aSlz 2025-05-05_17:56:12.430145_afyx 2025-05-05_17:56:12.430151_QLEe 2025-05-05_17:56:12.430159_LLVy 2025-05-05_17:56:12.430171_XXYY 2025-05-05_17:56:12.430177_WFth 2025-05-05_17:56:12.430184_hLxt 2025-05-05_17:56:12.430190_PISy

https://storage.googleapis.com/firebase-sdk-metric-reports/b22cTeHTxJ/index.html

fix more strict mode violation

6a3ccbc

themiswang requested a review from mrober May 5, 2025 17:38

google-oss-bot added the size/S label May 5, 2025

firebase deleted a comment from google-oss-bot May 5, 2025

mrober approved these changes May 5, 2025

View reviewed changes

themiswang merged commit f5ec0a6 into main May 5, 2025
45 checks passed

themiswang deleted the moreStrictMode branch May 5, 2025 18:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix more strict mode violation #6937

fix more strict mode violation #6937

themiswang commented May 5, 2025 •

edited

Loading

github-actions bot commented May 5, 2025 •

edited

Loading

github-actions bot commented May 5, 2025

google-oss-bot commented May 5, 2025

google-oss-bot commented May 5, 2025

`firebase-crashlytics`

github-actions bot commented May 5, 2025

google-oss-bot commented May 5, 2025

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`

fix more strict mode violation #6937

fix more strict mode violation #6937

Conversation

themiswang commented May 5, 2025 • edited Loading

github-actions bot commented May 5, 2025 • edited Loading

📝 PRs merging into main branch

github-actions bot commented May 5, 2025

Vertex AI Mock Responses Check ⚠️

google-oss-bot commented May 5, 2025

Coverage Report 1

Affected Products

Test Logs

google-oss-bot commented May 5, 2025

Size Report 1

Affected Products

firebase-crashlytics

Test Logs

github-actions bot commented May 5, 2025

Test Results

google-oss-bot commented May 5, 2025

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-rc

fire-sessions

timeToInitialDisplay

themiswang commented May 5, 2025 •

edited

Loading

github-actions bot commented May 5, 2025 •

edited

Loading

Coverage Report ¹

Size Report ¹

`firebase-crashlytics`

Startup Time Report ¹

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`