Skip to content

Enabled linting part2 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Enabled linting part2 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions firebase-database-collection/firebase-database-collection.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ apply plugin: 'com.android.library'
def androidVersion = 26

android {
lintOptions {
abortOnError false
}
compileSdkVersion androidVersion
}

Expand Down
4 changes: 1 addition & 3 deletions firebase-database/firebase-database.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ android {
multiDexEnabled true
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}
lintOptions {
abortOnError false
}

buildTypes {
release {
minifyEnabled false
Expand Down
2 changes: 0 additions & 2 deletions firebase-storage/firebase-storage.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ android {
multiDexEnabled true
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}
lintOptions {
}

buildTypes {
release {
Expand Down
3 changes: 0 additions & 3 deletions test-apps/database-test-app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ android {

vectorDrawables.useSupportLibrary true

lintOptions {
tasks.lint.enabled = false
}
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}

Expand Down
3 changes: 0 additions & 3 deletions test-apps/firestore-test-app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ android {

vectorDrawables.useSupportLibrary true

lintOptions {
tasks.lint.enabled = false
}
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}

Expand Down
8 changes: 8 additions & 0 deletions test-apps/firestore-test-app/lint.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<lint>
<!--gRPC's DNS name resolver checks for javax.naming at runtime to determine if it can be used, but fails gracefullt without it. This lint error is safe to ignore.-->
<!--See : https://github.com/grpc/grpc-java/blob/b0f423295b4674cb5247a6143fd211b050ef0065/core/src/main/java/io/grpc/internal/JndiResourceResolverFactory.java#L73-->
<issue id="InvalidPackage">
<ignore path="*/io.grpc/grpc-core/*"/>
</issue>
</lint>
3 changes: 0 additions & 3 deletions test-apps/functions-test-app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ android {
versionCode 1
versionName "1.0"
testInstrumentationRunner 'android.support.test.runner.AndroidJUnitRunner'
lintOptions {
tasks.lint.enabled = false
}
}

buildTypes {
Expand Down
3 changes: 0 additions & 3 deletions test-apps/storage-test-app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ android {

vectorDrawables.useSupportLibrary true

lintOptions {
tasks.lint.enabled = false
}
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}

Expand Down