Merge Kotlin Nullability into master #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age. (#602) * Add missing nullability annotations to Storage. * Remove redundant `@PublicApi` annotation. * Address review comments.
…B. (#603) * Add missing nullability annotations to RTDB. * Remove redundant `@PublicApi` annotations. * Update changelog.
* Add missing nullability annotations to Firestore. Additionally remove uses of the redundant `@PublicApi` annotation. * Remove varargs nullability annotations. As they don't have any effect on the resulting kotlin nullability. * gJF * Add androidx.annotation lint detector. The detector finds usages of non-androidx, non-android.support nullability annotations and provides automatic ide fixes for such violations. Android Support annotations are allowed as a transitional step until internal androidx migration is fully completed. * Change nullability check: * disable by default(will enable in a separate PR) * ignore kotlin source files * Address review comments * Address review comments. * ktlintFormat
* Fix timeouts in Functions. (#606) This commit resolves #604 by setting both the read and call timeouts. The connect and write timeouts are left at their default values of 10 seconds. * Report the correct version for the RTDB (#605) * Add missing package-info.java files for A/B Testing. The SDK doesn't have user-visible API, so it should be correctly annotated with javadoc's @hide.
|
/retest |
allisonbm92
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.