Skip to content

Small cleanup from lru port to webclient #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2018
Merged

Small cleanup from lru port to webclient #62

merged 2 commits into from
Oct 7, 2018

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Oct 6, 2018

Technically the in-memory pins don't get hit in that test, but we should set them up anyways so we don't have a NPE sitting around waiting.

Additionally, we were missing marking mutations in one case.

@gsoltis gsoltis self-assigned this Oct 6, 2018
@gsoltis gsoltis assigned schmidt-sebastian and unassigned gsoltis Oct 6, 2018
@gsoltis gsoltis merged commit 0bd8a18 into master Oct 7, 2018
@gsoltis gsoltis deleted the gsoltis/lru_cleanup branch October 7, 2018 21:55
@saurabhdtu saurabhdtu mentioned this pull request Nov 20, 2018
Closed
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsoltis @schmidt-sebastian @google-oss-bot