Skip to content

add release notes for componenets #6184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

davidmotson
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Aug 15, 2024

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

firebase-components

@VinayGuthal VinayGuthal self-requested a review August 15, 2024 15:38
@google-oss-bot
Copy link
Contributor

Copy link
Contributor

Unit Test Results

  24 files  +  16    24 suites  +16   18s ⏱️ -10s
115 tests +  93  115 ✔️ +  93  0 💤 ±0  0 ±0 
230 runs  +186  230 ✔️ +186  0 💤 ±0  0 ±0 

Results for commit 72d805a. ± Comparison against base commit db42bae.

This pull request removes 22 and adds 115 tests. Note that renamed tests count towards both.
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…
com.google.firebase.components.ComponentDiscoveryTest ‑ discoverLazy_whenRegistrarClassDoesNotExist_shouldReturnProviderThatReturnsNull
com.google.firebase.components.ComponentDiscoveryTest ‑ discoverLazy_whenRegistrarClassesAreInvalid_shouldReturnThrowingProviders
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldCorrectlyInstantiateValidComponentRegistrars
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipClassesThatDontImplementComponentRegistrarInterface
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipClassesWithNoDefaultConstructors
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipNonExistentClasses
com.google.firebase.components.ComponentDiscoveryTest ‑ discover_shouldSkipPrivateClasses
com.google.firebase.components.ComponentRuntimeTest ‑ container_shouldExposeAllProvidedInterfacesOfAComponent
com.google.firebase.components.ComponentRuntimeTest ‑ container_shouldExposeAllRegisteredSetValues
com.google.firebase.components.ComponentRuntimeTest ‑ container_withComponentProcessor_shouldDelegateToItForEachComponentRegistrar
…

@davidmotson davidmotson enabled auto-merge (squash) August 15, 2024 15:40
@davidmotson davidmotson merged commit b83910b into main Aug 15, 2024
32 checks passed
@davidmotson davidmotson deleted the davidmotson.release_componenets branch August 15, 2024 15:42
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • ComponentDiscovery

    DeviceStatisticsDistributions
    oriole-32
    Percentiledb42bae4fe6cc6DiffSignificant (?)
    p101.01 ±0.05 ms990 ±55 μs-20.7 μs (-2.1%)NO
    p251.09 ±0.04 ms1.07 ±0.06 ms-23.2 μs (-2.1%)NO
    p501.22 ±0.04 ms1.21 ±0.05 ms-13.7 μs (-1.1%)NO
    p751.41 ±0.07 ms1.42 ±0.05 ms+4.41 μs (+0.3%)NO
    p901.75 ±0.1 ms1.72 ±0.06 ms-31.0 μs (-1.8%)NO

    20 test runs in comparison
    CommitTest Runs
    db42bae
    • 2024-08-14_02:59:17.016259_iYrI
    • 2024-08-14_02:59:17.016303_avyc
    • 2024-08-14_02:59:17.016314_XSkU
    • 2024-08-14_02:59:17.016322_zDCU
    • 2024-08-14_02:59:17.016329_SNkp
    • 2024-08-14_02:59:17.016336_YFpr
    • 2024-08-14_02:59:17.016342_OipM
    • 2024-08-14_02:59:17.016349_jOYF
    • 2024-08-14_02:59:17.016355_VLSe
    • 2024-08-14_02:59:17.016363_qNUS
    4fe6cc6
    • 2024-08-15_15:47:01.615080_OIpn
    • 2024-08-15_15:47:01.615121_QvGX
    • 2024-08-15_15:47:01.615166_qVRb
    • 2024-08-15_15:47:01.615177_TJxB
    • 2024-08-15_15:47:01.615184_EUHj
    • 2024-08-15_15:47:01.615191_KYSt
    • 2024-08-15_15:47:01.615198_Xius
    • 2024-08-15_15:47:01.615204_Gqxr
    • 2024-08-15_15:47:01.615211_kktS
    • 2024-08-15_15:47:01.615217_WQNK
    redfin-30
    Percentiledb42bae4fe6cc6DiffSignificant (?)
    p10861 ±13 μs872 ±22 μs+10.7 μs (+1.2%)NO
    p25898 ±18 μs908 ±20 μs+10.4 μs (+1.2%)NO
    p50984 ±37 μs982 ±22 μs-2.33 μs (-0.2%)NO
    p751.21 ±0.08 ms1.23 ±0.05 ms+23.7 μs (+2.0%)NO
    p901.65 ±0.1 ms1.71 ±0.1 ms+61.3 μs (+3.7%)NO

    20 test runs in comparison
    CommitTest Runs
    db42bae
    • 2024-08-14_02:59:17.016259_iYrI
    • 2024-08-14_02:59:17.016303_avyc
    • 2024-08-14_02:59:17.016314_XSkU
    • 2024-08-14_02:59:17.016322_zDCU
    • 2024-08-14_02:59:17.016329_SNkp
    • 2024-08-14_02:59:17.016336_YFpr
    • 2024-08-14_02:59:17.016342_OipM
    • 2024-08-14_02:59:17.016349_jOYF
    • 2024-08-14_02:59:17.016355_VLSe
    • 2024-08-14_02:59:17.016363_qNUS
    4fe6cc6
    • 2024-08-15_15:47:01.615080_OIpn
    • 2024-08-15_15:47:01.615121_QvGX
    • 2024-08-15_15:47:01.615166_qVRb
    • 2024-08-15_15:47:01.615177_TJxB
    • 2024-08-15_15:47:01.615184_EUHj
    • 2024-08-15_15:47:01.615191_KYSt
    • 2024-08-15_15:47:01.615198_Xius
    • 2024-08-15_15:47:01.615204_Gqxr
    • 2024-08-15_15:47:01.615211_kktS
    • 2024-08-15_15:47:01.615217_WQNK
  • Firebase

    DeviceStatisticsDistributions
    oriole-32
    Percentiledb42bae4fe6cc6DiffSignificant (?)
    p107.11 ±0.2 ms6.92 ±0.2 ms-186 μs (-2.6%)NO
    p257.40 ±0.2 ms7.30 ±0.2 ms-104 μs (-1.4%)NO
    p507.97 ±0.2 ms7.84 ±0.2 ms-124 μs (-1.6%)NO
    p758.76 ±0.3 ms8.66 ±0.2 ms-103 μs (-1.2%)NO
    p909.77 ±0.3 ms9.50 ±0.2 ms-270 μs (-2.8%)NO

    20 test runs in comparison
    CommitTest Runs
    db42bae
    • 2024-08-14_02:59:17.016259_iYrI
    • 2024-08-14_02:59:17.016303_avyc
    • 2024-08-14_02:59:17.016314_XSkU
    • 2024-08-14_02:59:17.016322_zDCU
    • 2024-08-14_02:59:17.016329_SNkp
    • 2024-08-14_02:59:17.016336_YFpr
    • 2024-08-14_02:59:17.016342_OipM
    • 2024-08-14_02:59:17.016349_jOYF
    • 2024-08-14_02:59:17.016355_VLSe
    • 2024-08-14_02:59:17.016363_qNUS
    4fe6cc6
    • 2024-08-15_15:47:01.615080_OIpn
    • 2024-08-15_15:47:01.615121_QvGX
    • 2024-08-15_15:47:01.615166_qVRb
    • 2024-08-15_15:47:01.615177_TJxB
    • 2024-08-15_15:47:01.615184_EUHj
    • 2024-08-15_15:47:01.615191_KYSt
    • 2024-08-15_15:47:01.615198_Xius
    • 2024-08-15_15:47:01.615204_Gqxr
    • 2024-08-15_15:47:01.615211_kktS
    • 2024-08-15_15:47:01.615217_WQNK
    redfin-30
    Percentiledb42bae4fe6cc6DiffSignificant (?)
    p108.84 ±0.2 ms8.97 ±0.3 ms+130 μs (+1.5%)NO
    p259.11 ±0.2 ms9.26 ±0.2 ms+150 μs (+1.6%)NO
    p509.60 ±0.2 ms9.76 ±0.2 ms+153 μs (+1.6%)NO
    p7510.4 ±0.3 ms10.7 ±0.3 ms+263 μs (+2.5%)NO
    p9011.8 ±0.8 ms12.3 ±1 ms+433 μs (+3.7%)NO

    20 test runs in comparison
    CommitTest Runs
    db42bae
    • 2024-08-14_02:59:17.016259_iYrI
    • 2024-08-14_02:59:17.016303_avyc
    • 2024-08-14_02:59:17.016314_XSkU
    • 2024-08-14_02:59:17.016322_zDCU
    • 2024-08-14_02:59:17.016329_SNkp
    • 2024-08-14_02:59:17.016336_YFpr
    • 2024-08-14_02:59:17.016342_OipM
    • 2024-08-14_02:59:17.016349_jOYF
    • 2024-08-14_02:59:17.016355_VLSe
    • 2024-08-14_02:59:17.016363_qNUS
    4fe6cc6
    • 2024-08-15_15:47:01.615080_OIpn
    • 2024-08-15_15:47:01.615121_QvGX
    • 2024-08-15_15:47:01.615166_qVRb
    • 2024-08-15_15:47:01.615177_TJxB
    • 2024-08-15_15:47:01.615184_EUHj
    • 2024-08-15_15:47:01.615191_KYSt
    • 2024-08-15_15:47:01.615198_Xius
    • 2024-08-15_15:47:01.615204_Gqxr
    • 2024-08-15_15:47:01.615211_kktS
    • 2024-08-15_15:47:01.615217_WQNK
  • Runtime

    DeviceStatisticsDistributions
    oriole-32
    Percentiledb42bae4fe6cc6DiffSignificant (?)
    p105.93 ±0.2 ms5.76 ±0.1 ms-164 μs (-2.8%)NO
    p256.19 ±0.2 ms6.07 ±0.2 ms-115 μs (-1.9%)NO
    p506.63 ±0.2 ms6.52 ±0.2 ms-110 μs (-1.7%)NO
    p757.30 ±0.2 ms7.24 ±0.2 ms-63.0 μs (-0.9%)NO
    p908.12 ±0.3 ms8.01 ±0.3 ms-108 μs (-1.3%)NO

    20 test runs in comparison
    CommitTest Runs
    db42bae
    • 2024-08-14_02:59:17.016259_iYrI
    • 2024-08-14_02:59:17.016303_avyc
    • 2024-08-14_02:59:17.016314_XSkU
    • 2024-08-14_02:59:17.016322_zDCU
    • 2024-08-14_02:59:17.016329_SNkp
    • 2024-08-14_02:59:17.016336_YFpr
    • 2024-08-14_02:59:17.016342_OipM
    • 2024-08-14_02:59:17.016349_jOYF
    • 2024-08-14_02:59:17.016355_VLSe
    • 2024-08-14_02:59:17.016363_qNUS
    4fe6cc6
    • 2024-08-15_15:47:01.615080_OIpn
    • 2024-08-15_15:47:01.615121_QvGX
    • 2024-08-15_15:47:01.615166_qVRb
    • 2024-08-15_15:47:01.615177_TJxB
    • 2024-08-15_15:47:01.615184_EUHj
    • 2024-08-15_15:47:01.615191_KYSt
    • 2024-08-15_15:47:01.615198_Xius
    • 2024-08-15_15:47:01.615204_Gqxr
    • 2024-08-15_15:47:01.615211_kktS
    • 2024-08-15_15:47:01.615217_WQNK
    redfin-30
    Percentiledb42bae4fe6cc6DiffSignificant (?)
    p107.80 ±0.1 ms7.89 ±0.2 ms+91.4 μs (+1.2%)NO
    p258.02 ±0.1 ms8.19 ±0.2 ms+165 μs (+2.1%)NO
    p508.41 ±0.1 ms8.56 ±0.2 ms+148 μs (+1.8%)NO
    p758.95 ±0.2 ms9.18 ±0.2 ms+232 μs (+2.6%)NO
    p9010.1 ±0.7 ms10.3 ±0.6 ms+220 μs (+2.2%)NO

    20 test runs in comparison
    CommitTest Runs
    db42bae
    • 2024-08-14_02:59:17.016259_iYrI
    • 2024-08-14_02:59:17.016303_avyc
    • 2024-08-14_02:59:17.016314_XSkU
    • 2024-08-14_02:59:17.016322_zDCU
    • 2024-08-14_02:59:17.016329_SNkp
    • 2024-08-14_02:59:17.016336_YFpr
    • 2024-08-14_02:59:17.016342_OipM
    • 2024-08-14_02:59:17.016349_jOYF
    • 2024-08-14_02:59:17.016355_VLSe
    • 2024-08-14_02:59:17.016363_qNUS
    4fe6cc6
    • 2024-08-15_15:47:01.615080_OIpn
    • 2024-08-15_15:47:01.615121_QvGX
    • 2024-08-15_15:47:01.615166_qVRb
    • 2024-08-15_15:47:01.615177_TJxB
    • 2024-08-15_15:47:01.615184_EUHj
    • 2024-08-15_15:47:01.615191_KYSt
    • 2024-08-15_15:47:01.615198_Xius
    • 2024-08-15_15:47:01.615204_Gqxr
    • 2024-08-15_15:47:01.615211_kktS
    • 2024-08-15_15:47:01.615217_WQNK
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentiledb42bae4fe6cc6DiffSignificant (?)
    p10201 ±4 ms205 ±3 ms+4.42 ms (+2.2%)NO
    p25207 ±3 ms211 ±3 ms+4.55 ms (+2.2%)NO
    p50213 ±4 ms219 ±4 ms+5.63 ms (+2.6%)NO
    p75222 ±3 ms227 ±4 ms+4.82 ms (+2.2%)NO
    p90230 ±5 ms237 ±4 ms+6.64 ms (+2.9%)NO

    20 test runs in comparison
    CommitTest Runs
    db42bae
    • 2024-08-14_02:59:17.016259_iYrI
    • 2024-08-14_02:59:17.016303_avyc
    • 2024-08-14_02:59:17.016314_XSkU
    • 2024-08-14_02:59:17.016322_zDCU
    • 2024-08-14_02:59:17.016329_SNkp
    • 2024-08-14_02:59:17.016336_YFpr
    • 2024-08-14_02:59:17.016342_OipM
    • 2024-08-14_02:59:17.016349_jOYF
    • 2024-08-14_02:59:17.016355_VLSe
    • 2024-08-14_02:59:17.016363_qNUS
    4fe6cc6
    • 2024-08-15_15:47:01.615080_OIpn
    • 2024-08-15_15:47:01.615121_QvGX
    • 2024-08-15_15:47:01.615166_qVRb
    • 2024-08-15_15:47:01.615177_TJxB
    • 2024-08-15_15:47:01.615184_EUHj
    • 2024-08-15_15:47:01.615191_KYSt
    • 2024-08-15_15:47:01.615198_Xius
    • 2024-08-15_15:47:01.615204_Gqxr
    • 2024-08-15_15:47:01.615211_kktS
    • 2024-08-15_15:47:01.615217_WQNK
    redfin-30
    Percentiledb42bae4fe6cc6DiffSignificant (?)
    p10242 ±3 ms265 ±4 ms+22.4 ms (+9.3%)YES
    p25248 ±3 ms271 ±4 ms+23.5 ms (+9.5%)YES
    p50255 ±4 ms278 ±4 ms+23.9 ms (+9.4%)YES
    p75262 ±4 ms287 ±5 ms+24.7 ms (+9.4%)YES
    p90270 ±5 ms301 ±8 ms+30.7 ms (+11.4%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    db42bae
    • 2024-08-14_02:59:17.016259_iYrI
    • 2024-08-14_02:59:17.016303_avyc
    • 2024-08-14_02:59:17.016314_XSkU
    • 2024-08-14_02:59:17.016322_zDCU
    • 2024-08-14_02:59:17.016329_SNkp
    • 2024-08-14_02:59:17.016336_YFpr
    • 2024-08-14_02:59:17.016342_OipM
    • 2024-08-14_02:59:17.016349_jOYF
    • 2024-08-14_02:59:17.016355_VLSe
    • 2024-08-14_02:59:17.016363_qNUS
    4fe6cc6
    • 2024-08-15_15:47:01.615080_OIpn
    • 2024-08-15_15:47:01.615121_QvGX
    • 2024-08-15_15:47:01.615166_qVRb
    • 2024-08-15_15:47:01.615177_TJxB
    • 2024-08-15_15:47:01.615184_EUHj
    • 2024-08-15_15:47:01.615191_KYSt
    • 2024-08-15_15:47:01.615198_Xius
    • 2024-08-15_15:47:01.615204_Gqxr
    • 2024-08-15_15:47:01.615211_kktS
    • 2024-08-15_15:47:01.615217_WQNK

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QsazP7SjhI/index.html

@firebase firebase locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants