Add a CrashlyticsWorkers container to manage the workers #6178

mrober · 2024-08-12T17:36:35Z

Add a CrashlyticsWorkers container to manage the workers, and define what each one is for. Also added a submitTaskOnSuccess method for convenience. This will be useful for any of the user actions that get triggered by send unsent reports.

Also found and fixed a bug in the worker queue. If a task gets cancelled and is followed by a runnable or callable already in the queue, it would have been skipped. Now it's not a problem, and a test case added.

github-actions · 2024-08-12T17:36:49Z

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

google-oss-bot · 2024-08-12T17:44:17Z

Coverage Report ¹

Affected Products

`firebase-crashlytics`

Overall coverage changed from 11.13% (08deb69) to 11.27% (ee12c98) by +0.14%.

Filename	Base (`08deb69`)	Merge (`ee12c98`)	Diff
CrashlyticsController.java	16.58%	16.18%	-0.40%
CrashlyticsCore.java	0.61%	0.61%	-0.00%
CrashlyticsWorker.java	30.30%	23.26%	-7.05%
CrashlyticsWorkers.kt	?	26.32%	?
DataCollectionArbiter.java	83.33%	84.27%	+0.94%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/I3LaovE5AI.html

github-actions · 2024-08-12T17:49:29Z

Unit Test Results

  8 files -   178   8 suites - 178 27s ⏱️ - 4m 12s
22 tests - 1 212 22 ✔️ - 1 196 0 💤 - 16 0 ❌ ±0
44 runs - 2 448 44 ✔️ - 2 416 0 💤 - 32 0 ❌ ±0

Results for commit 03fb48d. ± Comparison against base commit 08deb69.

♻️ This comment has been updated with latest results.

google-oss-bot · 2024-08-12T17:49:44Z

Size Report ¹

Affected Products

firebase-crashlytics
Type Base (08deb69) Merge (ee12c98) Diff
aar 417 kB 410 kB -6.71 kB (-1.6%)
apk (aggressive) 697 kB 698 kB +716 B (+0.1%)
apk (release) 5.85 MB 5.85 MB -4.70 kB (-0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/0WNaaVAMLa.html

google-oss-bot · 2024-08-12T18:12:49Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (08deb69) and the CI merge commit (ee12c98)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 08deb69: https://storage.googleapis.com/firebase-sdk-metric-reports/sF2LR7qUlk/index.html
- ee12c98: https://storage.googleapis.com/firebase-sdk-metric-reports/6RuKYy6BTV/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`08deb69`	`ee12c98`	Diff	Significant (?)
p10	11.2 ±2 ms	9.83 ±1 ms	-1.38 ms (-12.3%)	NO
p25	11.8 ±2 ms	10.5 ±1 ms	-1.35 ms (-11.4%)	NO
p50	12.9 ±2 ms	11.3 ±1 ms	-1.55 ms (-12.0%)	NO
p75	14.3 ±2 ms	12.5 ±2 ms	-1.85 ms (-13.0%)	NO
p90	16.2 ±3 ms	13.9 ±2 ms	-2.31 ms (-14.3%)	NO

20 test runs in comparison

Commit	Test Runs
`08deb69`	2024-08-12_16:45:45.130031_IGpv 2024-08-12_16:45:45.130073_wxnP 2024-08-12_16:45:45.130082_MbmW 2024-08-12_16:45:45.130098_yuXv 2024-08-12_16:45:45.130104_bMEu 2024-08-12_16:45:45.130111_EBmU 2024-08-12_16:45:45.130117_NxCQ 2024-08-12_16:45:45.130140_AwFI 2024-08-12_16:45:45.130147_pAof 2024-08-12_16:45:45.130154_Gvwx
`ee12c98`	2024-08-12_19:45:44.832617_kKOz 2024-08-12_19:45:44.832659_BILS 2024-08-12_19:45:44.832669_oGGx 2024-08-12_19:45:44.832684_xPli 2024-08-12_19:45:44.832692_hscz 2024-08-12_19:45:44.832699_QAXN 2024-08-12_19:45:44.832707_GsgM 2024-08-12_19:45:44.832714_nLIo 2024-08-12_19:45:44.832720_LBTT 2024-08-12_19:45:44.832727_xZIc

redfin-30

Percentile	`08deb69`	`ee12c98`	Diff	Significant (?)
p10	15.7 ±6 ms	15.6 ±6 ms	-112 μs (-0.7%)	NO
p25	16.7 ±6 ms	16.5 ±7 ms	-134 μs (-0.8%)	NO
p50	17.8 ±7 ms	17.8 ±8 ms	-5.05 μs (-0.0%)	NO
p75	19.6 ±8 ms	19.4 ±9 ms	-205 μs (-1.0%)	NO
p90	21.5 ±9 ms	21.4 ±10 ms	-153 μs (-0.7%)	NO

20 test runs in comparison

Commit	Test Runs
`08deb69`	2024-08-12_16:45:45.130031_IGpv 2024-08-12_16:45:45.130073_wxnP 2024-08-12_16:45:45.130082_MbmW 2024-08-12_16:45:45.130098_yuXv 2024-08-12_16:45:45.130104_bMEu 2024-08-12_16:45:45.130111_EBmU 2024-08-12_16:45:45.130117_NxCQ 2024-08-12_16:45:45.130140_AwFI 2024-08-12_16:45:45.130147_pAof 2024-08-12_16:45:45.130154_Gvwx
`ee12c98`	2024-08-12_19:45:44.832617_kKOz 2024-08-12_19:45:44.832659_BILS 2024-08-12_19:45:44.832669_oGGx 2024-08-12_19:45:44.832684_xPli 2024-08-12_19:45:44.832692_hscz 2024-08-12_19:45:44.832699_QAXN 2024-08-12_19:45:44.832707_GsgM 2024-08-12_19:45:44.832714_nLIo 2024-08-12_19:45:44.832720_LBTT 2024-08-12_19:45:44.832727_xZIc

`fire-rc`

Device Statistics Distributions

oriole-32

Percentile	`08deb69`	`ee12c98`	Diff	Significant (?)
p10	96.3 ±41 μs	327 ±387 μs	+231 μs (+239.7%)	NO
p25	101 ±43 μs	341 ±402 μs	+240 μs (+236.7%)	NO
p50	110 ±47 μs	361 ±419 μs	+251 μs (+227.9%)	NO
p75	133 ±64 μs	393 ±440 μs	+260 μs (+195.6%)	NO
p90	166 ±67 μs	471 ±498 μs	+305 μs (+184.0%)	NO

20 test runs in comparison

Commit	Test Runs
`08deb69`	2024-08-12_16:45:45.130031_IGpv 2024-08-12_16:45:45.130073_wxnP 2024-08-12_16:45:45.130082_MbmW 2024-08-12_16:45:45.130098_yuXv 2024-08-12_16:45:45.130104_bMEu 2024-08-12_16:45:45.130111_EBmU 2024-08-12_16:45:45.130117_NxCQ 2024-08-12_16:45:45.130140_AwFI 2024-08-12_16:45:45.130147_pAof 2024-08-12_16:45:45.130154_Gvwx
`ee12c98`	2024-08-12_19:45:44.832617_kKOz 2024-08-12_19:45:44.832659_BILS 2024-08-12_19:45:44.832669_oGGx 2024-08-12_19:45:44.832684_xPli 2024-08-12_19:45:44.832692_hscz 2024-08-12_19:45:44.832699_QAXN 2024-08-12_19:45:44.832707_GsgM 2024-08-12_19:45:44.832714_nLIo 2024-08-12_19:45:44.832720_LBTT 2024-08-12_19:45:44.832727_xZIc

redfin-30

Percentile	`08deb69`	`ee12c98`	Diff	Significant (?)
p10	328 ±328 μs	356 ±486 μs	+27.4 μs (+8.3%)	NO
p25	394 ±421 μs	393 ±567 μs	-1.00 μs (-0.3%)	NO
p50	489 ±515 μs	459 ±673 μs	-29.6 μs (-6.1%)	NO
p75	608 ±634 μs	562 ±826 μs	-45.6 μs (-7.5%)	NO
p90	818 ±919 μs	779 ±1102 μs	-39.5 μs (-4.8%)	NO

20 test runs in comparison

Commit	Test Runs
`08deb69`	2024-08-12_16:45:45.130031_IGpv 2024-08-12_16:45:45.130073_wxnP 2024-08-12_16:45:45.130082_MbmW 2024-08-12_16:45:45.130098_yuXv 2024-08-12_16:45:45.130104_bMEu 2024-08-12_16:45:45.130111_EBmU 2024-08-12_16:45:45.130117_NxCQ 2024-08-12_16:45:45.130140_AwFI 2024-08-12_16:45:45.130147_pAof 2024-08-12_16:45:45.130154_Gvwx
`ee12c98`	2024-08-12_19:45:44.832617_kKOz 2024-08-12_19:45:44.832659_BILS 2024-08-12_19:45:44.832669_oGGx 2024-08-12_19:45:44.832684_xPli 2024-08-12_19:45:44.832692_hscz 2024-08-12_19:45:44.832699_QAXN 2024-08-12_19:45:44.832707_GsgM 2024-08-12_19:45:44.832714_nLIo 2024-08-12_19:45:44.832720_LBTT 2024-08-12_19:45:44.832727_xZIc

`fire-sessions`

Device Statistics Distributions

oriole-32

Percentile	`08deb69`	`ee12c98`	Diff	Significant (?)
p10	2.56 ±0.6 ms	2.68 ±0.3 ms	+128 μs (+5.0%)	NO
p25	2.75 ±0.6 ms	2.81 ±0.3 ms	+66.4 μs (+2.4%)	NO
p50	3.09 ±0.7 ms	3.13 ±0.3 ms	+44.0 μs (+1.4%)	NO
p75	3.54 ±0.7 ms	3.75 ±0.5 ms	+209 μs (+5.9%)	NO
p90	4.19 ±0.8 ms	4.48 ±0.6 ms	+289 μs (+6.9%)	NO

20 test runs in comparison

Commit	Test Runs
`08deb69`	2024-08-12_16:45:45.130031_IGpv 2024-08-12_16:45:45.130073_wxnP 2024-08-12_16:45:45.130082_MbmW 2024-08-12_16:45:45.130098_yuXv 2024-08-12_16:45:45.130104_bMEu 2024-08-12_16:45:45.130111_EBmU 2024-08-12_16:45:45.130117_NxCQ 2024-08-12_16:45:45.130140_AwFI 2024-08-12_16:45:45.130147_pAof 2024-08-12_16:45:45.130154_Gvwx
`ee12c98`	2024-08-12_19:45:44.832617_kKOz 2024-08-12_19:45:44.832659_BILS 2024-08-12_19:45:44.832669_oGGx 2024-08-12_19:45:44.832684_xPli 2024-08-12_19:45:44.832692_hscz 2024-08-12_19:45:44.832699_QAXN 2024-08-12_19:45:44.832707_GsgM 2024-08-12_19:45:44.832714_nLIo 2024-08-12_19:45:44.832720_LBTT 2024-08-12_19:45:44.832727_xZIc

redfin-30

Percentile	`08deb69`	`ee12c98`	Diff	Significant (?)
p10	6.45 ±2 ms	5.76 ±1 ms	-688 μs (-10.7%)	NO
p25	6.95 ±2 ms	6.23 ±2 ms	-722 μs (-10.4%)	NO
p50	7.97 ±3 ms	6.72 ±2 ms	-1.25 ms (-15.7%)	NO
p75	9.24 ±5 ms	7.23 ±3 ms	-2.01 ms (-21.8%)	NO
p90	10.5 ±6 ms	7.85 ±4 ms	-2.63 ms (-25.1%)	NO

20 test runs in comparison

Commit	Test Runs
`08deb69`	2024-08-12_16:45:45.130031_IGpv 2024-08-12_16:45:45.130073_wxnP 2024-08-12_16:45:45.130082_MbmW 2024-08-12_16:45:45.130098_yuXv 2024-08-12_16:45:45.130104_bMEu 2024-08-12_16:45:45.130111_EBmU 2024-08-12_16:45:45.130117_NxCQ 2024-08-12_16:45:45.130140_AwFI 2024-08-12_16:45:45.130147_pAof 2024-08-12_16:45:45.130154_Gvwx
`ee12c98`	2024-08-12_19:45:44.832617_kKOz 2024-08-12_19:45:44.832659_BILS 2024-08-12_19:45:44.832669_oGGx 2024-08-12_19:45:44.832684_xPli 2024-08-12_19:45:44.832692_hscz 2024-08-12_19:45:44.832699_QAXN 2024-08-12_19:45:44.832707_GsgM 2024-08-12_19:45:44.832714_nLIo 2024-08-12_19:45:44.832720_LBTT 2024-08-12_19:45:44.832727_xZIc

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`08deb69`	`ee12c98`	Diff	Significant (?)
p10	204 ±7 ms	206 ±2 ms	+2.63 ms (+1.3%)	NO
p25	210 ±7 ms	212 ±3 ms	+2.15 ms (+1.0%)	NO
p50	217 ±9 ms	220 ±3 ms	+3.09 ms (+1.4%)	NO
p75	225 ±11 ms	228 ±3 ms	+2.29 ms (+1.0%)	NO
p90	237 ±23 ms	239 ±6 ms	+1.81 ms (+0.8%)	NO

20 test runs in comparison

Commit	Test Runs
`08deb69`	2024-08-12_16:45:45.130031_IGpv 2024-08-12_16:45:45.130073_wxnP 2024-08-12_16:45:45.130082_MbmW 2024-08-12_16:45:45.130098_yuXv 2024-08-12_16:45:45.130104_bMEu 2024-08-12_16:45:45.130111_EBmU 2024-08-12_16:45:45.130117_NxCQ 2024-08-12_16:45:45.130140_AwFI 2024-08-12_16:45:45.130147_pAof 2024-08-12_16:45:45.130154_Gvwx
`ee12c98`	2024-08-12_19:45:44.832617_kKOz 2024-08-12_19:45:44.832659_BILS 2024-08-12_19:45:44.832669_oGGx 2024-08-12_19:45:44.832684_xPli 2024-08-12_19:45:44.832692_hscz 2024-08-12_19:45:44.832699_QAXN 2024-08-12_19:45:44.832707_GsgM 2024-08-12_19:45:44.832714_nLIo 2024-08-12_19:45:44.832720_LBTT 2024-08-12_19:45:44.832727_xZIc

redfin-30

Percentile	`08deb69`	`ee12c98`	Diff	Significant (?)
p10	242 ±4 ms	264 ±6 ms	+22.0 ms (+9.1%)	MAYBE
p25	247 ±4 ms	270 ±6 ms	+22.4 ms (+9.1%)	MAYBE
p50	254 ±4 ms	276 ±7 ms	+22.1 ms (+8.7%)	MAYBE
p75	261 ±5 ms	284 ±7 ms	+23.4 ms (+9.0%)	MAYBE
p90	269 ±6 ms	296 ±10 ms	+27.0 ms (+10.0%)	NO

20 test runs in comparison

Commit	Test Runs
`08deb69`	2024-08-12_16:45:45.130031_IGpv 2024-08-12_16:45:45.130073_wxnP 2024-08-12_16:45:45.130082_MbmW 2024-08-12_16:45:45.130098_yuXv 2024-08-12_16:45:45.130104_bMEu 2024-08-12_16:45:45.130111_EBmU 2024-08-12_16:45:45.130117_NxCQ 2024-08-12_16:45:45.130140_AwFI 2024-08-12_16:45:45.130147_pAof 2024-08-12_16:45:45.130154_Gvwx
`ee12c98`	2024-08-12_19:45:44.832617_kKOz 2024-08-12_19:45:44.832659_BILS 2024-08-12_19:45:44.832669_oGGx 2024-08-12_19:45:44.832684_xPli 2024-08-12_19:45:44.832692_hscz 2024-08-12_19:45:44.832699_QAXN 2024-08-12_19:45:44.832707_GsgM 2024-08-12_19:45:44.832714_nLIo 2024-08-12_19:45:44.832720_LBTT 2024-08-12_19:45:44.832727_xZIc

https://storage.googleapis.com/firebase-sdk-metric-reports/HPfMB83MNx/index.html

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/Utils.java

...cs/src/main/java/com/google/firebase/crashlytics/internal/concurrency/CrashlyticsWorker.java

themiswang

Woooh thank you for the refactoring!

mrober · 2024-08-12T19:43:39Z

#4345

…)" This reverts commit 9535f94.

mrober added 5 commits August 12, 2024 13:18

Add CrashlyticsWorkers container and plumb it through

ef591d4

Delete CrashlyticsBackgroundWorker.java

a0cee58

Make CrashlyticsWorker an Executor, also fixed cancellation bug

f2ab709

Add submitTaskOnSuccess method to CrashlyticsWorker

7005ce8

Clean up CrashlyticsWorkers, and fix some comments

ebbf526

mrober added no-changelog main-merge-ack labels Aug 12, 2024

mrober requested a review from themiswang August 12, 2024 17:36

google-oss-bot added the size/XXL label Aug 12, 2024

Format

fded039

themiswang reviewed Aug 12, 2024

View reviewed changes

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/Utils.java Show resolved Hide resolved

themiswang reviewed Aug 12, 2024

View reviewed changes

...cs/src/main/java/com/google/firebase/crashlytics/internal/concurrency/CrashlyticsWorker.java Show resolved Hide resolved

themiswang approved these changes Aug 12, 2024

View reviewed changes

Address feedback

03fb48d

mrober merged commit 9535f94 into main Aug 12, 2024
41 of 42 checks passed

mrober deleted the crashlytics-workers branch August 12, 2024 19:42

mrober added a commit that referenced this pull request Aug 19, 2024

Revert "Add a CrashlyticsWorkers container to manage the workers (#6178…

198a536

…)" This reverts commit 9535f94.

firebase locked and limited conversation to collaborators Sep 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a CrashlyticsWorkers container to manage the workers #6178

Add a CrashlyticsWorkers container to manage the workers #6178

mrober commented Aug 12, 2024

github-actions bot commented Aug 12, 2024 •

edited

Loading

google-oss-bot commented Aug 12, 2024 •

edited

Loading

`firebase-crashlytics`

github-actions bot commented Aug 12, 2024 •

edited

Loading

google-oss-bot commented Aug 12, 2024 •

edited

Loading

`firebase-crashlytics`

google-oss-bot commented Aug 12, 2024 •

edited

Loading

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`

themiswang left a comment

mrober commented Aug 12, 2024

Add a CrashlyticsWorkers container to manage the workers #6178

Add a CrashlyticsWorkers container to manage the workers #6178

Conversation

mrober commented Aug 12, 2024

github-actions bot commented Aug 12, 2024 • edited Loading

Release note changes

google-oss-bot commented Aug 12, 2024 • edited Loading

Coverage Report 1

Affected Products

firebase-crashlytics

Test Logs

github-actions bot commented Aug 12, 2024 • edited Loading

Unit Test Results

google-oss-bot commented Aug 12, 2024 • edited Loading

Size Report 1

Affected Products

firebase-crashlytics

Test Logs

google-oss-bot commented Aug 12, 2024 • edited Loading

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-rc

fire-sessions

timeToInitialDisplay

themiswang left a comment

Choose a reason for hiding this comment

mrober commented Aug 12, 2024

github-actions bot commented Aug 12, 2024 •

edited

Loading

google-oss-bot commented Aug 12, 2024 •

edited

Loading

Coverage Report ¹

`firebase-crashlytics`

github-actions bot commented Aug 12, 2024 •

edited

Loading

google-oss-bot commented Aug 12, 2024 •

edited

Loading

Size Report ¹

`firebase-crashlytics`

google-oss-bot commented Aug 12, 2024 •

edited

Loading

Startup Time Report ¹

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`