move more jobs to disk write #6156

themiswang · 2024-08-06T03:00:37Z

Move file clean up task to disk write worker.
Fix unit test: close session has to run on a background thread

github-actions · 2024-08-06T03:00:49Z

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

google-oss-bot · 2024-08-06T03:01:15Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2024-08-06T03:04:59Z

Coverage Report ¹

Affected Products

`firebase-crashlytics`

Overall coverage changed from 11.27% (9017c35) to 11.58% (5beb95a) by +0.31%.

Filename	Base (`9017c35`)	Merge (`5beb95a`)	Diff
CrashlyticsController.java	16.18%	18.42%	+2.24%
CrashlyticsWorker.java	23.26%	37.21%	+13.95%
CrashlyticsWorkers.kt	26.32%	57.89%	+31.58%
SessionReportingCoordinator.java	42.44%	41.71%	-0.73%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/UTnltvLqX8.html

google-oss-bot · 2024-08-06T03:17:06Z

Size Report ¹

Affected Products

firebase-crashlytics
Type Base (9017c35) Merge (5beb95a) Diff
aar 410 kB 410 kB +385 B (+0.1%)
apk (aggressive) 698 kB 698 kB +100 B (+0.0%)
apk (release) 5.85 MB 5.85 MB +820 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/eIjECeamKR.html

google-oss-bot · 2024-08-06T03:38:37Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (9017c35) and the CI merge commit (5beb95a)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 9017c35: https://storage.googleapis.com/firebase-sdk-metric-reports/05qBDujP7G/index.html
- 5beb95a: https://storage.googleapis.com/firebase-sdk-metric-reports/cbcH0XyUcm/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`9017c35`	`5beb95a`	Diff	Significant (?)
p10	10.2 ±1 ms	10.1 ±2 ms	-89.1 μs (-0.9%)	NO
p25	10.8 ±1 ms	10.7 ±2 ms	-105 μs (-1.0%)	NO
p50	11.6 ±2 ms	11.6 ±2 ms	+36.6 μs (+0.3%)	NO
p75	12.7 ±2 ms	12.8 ±3 ms	+151 μs (+1.2%)	NO
p90	14.1 ±2 ms	14.2 ±3 ms	+42.1 μs (+0.3%)	NO

20 test runs in comparison

Commit	Test Runs
`9017c35`	2024-08-12_21:34:34.943821_zmot 2024-08-12_21:34:34.943866_OhxB 2024-08-12_21:34:34.943878_nLGG 2024-08-12_21:34:34.943886_GyZj 2024-08-12_21:34:34.943893_GaKs 2024-08-12_21:34:34.943900_uMXJ 2024-08-12_21:34:34.943907_iYXd 2024-08-12_21:34:34.943913_zpyn 2024-08-12_21:34:34.943920_rTIf 2024-08-12_21:34:34.943927_UKWy
`5beb95a`	2024-08-13_23:24:55.185292_EUSZ 2024-08-13_23:24:55.185339_FPcy 2024-08-13_23:24:55.185348_xIIP 2024-08-13_23:24:55.185355_tnRN 2024-08-13_23:24:55.185361_hmef 2024-08-13_23:24:55.185367_OYsE 2024-08-13_23:24:55.185374_vHUm 2024-08-13_23:24:55.185381_nwqb 2024-08-13_23:24:55.185387_Tdhy 2024-08-13_23:24:55.185393_mcrM

redfin-30

Percentile	`9017c35`	`5beb95a`	Diff	Significant (?)
p10	17.1 ±7 ms	16.5 ±5 ms	-662 μs (-3.9%)	NO
p25	18.5 ±7 ms	17.5 ±6 ms	-924 μs (-5.0%)	NO
p50	20.2 ±8 ms	19.3 ±7 ms	-939 μs (-4.6%)	NO
p75	22.1 ±9.6 ms	21.3 ±9 ms	-805 μs (-3.6%)	NO
p90	24.4 ±10 ms	24.3 ±10 ms	-151 μs (-0.6%)	NO

20 test runs in comparison

Commit	Test Runs
`9017c35`	2024-08-12_21:34:34.943821_zmot 2024-08-12_21:34:34.943866_OhxB 2024-08-12_21:34:34.943878_nLGG 2024-08-12_21:34:34.943886_GyZj 2024-08-12_21:34:34.943893_GaKs 2024-08-12_21:34:34.943900_uMXJ 2024-08-12_21:34:34.943907_iYXd 2024-08-12_21:34:34.943913_zpyn 2024-08-12_21:34:34.943920_rTIf 2024-08-12_21:34:34.943927_UKWy
`5beb95a`	2024-08-13_23:24:55.185292_EUSZ 2024-08-13_23:24:55.185339_FPcy 2024-08-13_23:24:55.185348_xIIP 2024-08-13_23:24:55.185355_tnRN 2024-08-13_23:24:55.185361_hmef 2024-08-13_23:24:55.185367_OYsE 2024-08-13_23:24:55.185374_vHUm 2024-08-13_23:24:55.185381_nwqb 2024-08-13_23:24:55.185387_Tdhy 2024-08-13_23:24:55.185393_mcrM

`fire-rc`

Device Statistics Distributions

oriole-32

Percentile	`9017c35`	`5beb95a`	Diff	Significant (?)
p10	349 ±358 μs	243 ±248 μs	-105 μs (-30.2%)	NO
p25	364 ±367 μs	257 ±257 μs	-107 μs (-29.3%)	NO
p50	391 ±383 μs	280 ±266 μs	-111 μs (-28.5%)	NO
p75	421 ±397 μs	333 ±279 μs	-87.9 μs (-20.9%)	NO
p90	483 ±422 μs	425 ±328 μs	-58.2 μs (-12.0%)	NO

20 test runs in comparison

Commit	Test Runs
`9017c35`	2024-08-12_21:34:34.943821_zmot 2024-08-12_21:34:34.943866_OhxB 2024-08-12_21:34:34.943878_nLGG 2024-08-12_21:34:34.943886_GyZj 2024-08-12_21:34:34.943893_GaKs 2024-08-12_21:34:34.943900_uMXJ 2024-08-12_21:34:34.943907_iYXd 2024-08-12_21:34:34.943913_zpyn 2024-08-12_21:34:34.943920_rTIf 2024-08-12_21:34:34.943927_UKWy
`5beb95a`	2024-08-13_23:24:55.185292_EUSZ 2024-08-13_23:24:55.185339_FPcy 2024-08-13_23:24:55.185348_xIIP 2024-08-13_23:24:55.185355_tnRN 2024-08-13_23:24:55.185361_hmef 2024-08-13_23:24:55.185367_OYsE 2024-08-13_23:24:55.185374_vHUm 2024-08-13_23:24:55.185381_nwqb 2024-08-13_23:24:55.185387_Tdhy 2024-08-13_23:24:55.185393_mcrM

redfin-30

Percentile	`9017c35`	`5beb95a`	Diff	Significant (?)
p10	547 ±644 μs	664 ±727 μs	+117 μs (+21.4%)	NO
p25	632 ±776 μs	767 ±874 μs	+135 μs (+21.4%)	NO
p50	742 ±937 μs	882 ±1024 μs	+140 μs (+18.9%)	NO
p75	865 ±1102 μs	1.06 ±1 ms	+191 μs (+22.1%)	NO
p90	1.01 ±1 ms	1.29 ±1 ms	+284 μs (+28.3%)	NO

20 test runs in comparison

Commit	Test Runs
`9017c35`	2024-08-12_21:34:34.943821_zmot 2024-08-12_21:34:34.943866_OhxB 2024-08-12_21:34:34.943878_nLGG 2024-08-12_21:34:34.943886_GyZj 2024-08-12_21:34:34.943893_GaKs 2024-08-12_21:34:34.943900_uMXJ 2024-08-12_21:34:34.943907_iYXd 2024-08-12_21:34:34.943913_zpyn 2024-08-12_21:34:34.943920_rTIf 2024-08-12_21:34:34.943927_UKWy
`5beb95a`	2024-08-13_23:24:55.185292_EUSZ 2024-08-13_23:24:55.185339_FPcy 2024-08-13_23:24:55.185348_xIIP 2024-08-13_23:24:55.185355_tnRN 2024-08-13_23:24:55.185361_hmef 2024-08-13_23:24:55.185367_OYsE 2024-08-13_23:24:55.185374_vHUm 2024-08-13_23:24:55.185381_nwqb 2024-08-13_23:24:55.185387_Tdhy 2024-08-13_23:24:55.185393_mcrM

`fire-sessions`

Device Statistics Distributions

oriole-32

Percentile	`9017c35`	`5beb95a`	Diff	Significant (?)
p10	2.86 ±0.7 ms	3.54 ±1 ms	+679 μs (+23.7%)	NO
p25	3.04 ±0.7 ms	3.82 ±2 ms	+776 μs (+25.5%)	NO
p50	3.41 ±0.7 ms	4.18 ±2 ms	+770 μs (+22.6%)	NO
p75	4.08 ±0.7 ms	4.85 ±2 ms	+771 μs (+18.9%)	NO
p90	4.88 ±0.8 ms	5.83 ±2 ms	+957 μs (+19.6%)	NO

20 test runs in comparison

Commit	Test Runs
`9017c35`	2024-08-12_21:34:34.943821_zmot 2024-08-12_21:34:34.943866_OhxB 2024-08-12_21:34:34.943878_nLGG 2024-08-12_21:34:34.943886_GyZj 2024-08-12_21:34:34.943893_GaKs 2024-08-12_21:34:34.943900_uMXJ 2024-08-12_21:34:34.943907_iYXd 2024-08-12_21:34:34.943913_zpyn 2024-08-12_21:34:34.943920_rTIf 2024-08-12_21:34:34.943927_UKWy
`5beb95a`	2024-08-13_23:24:55.185292_EUSZ 2024-08-13_23:24:55.185339_FPcy 2024-08-13_23:24:55.185348_xIIP 2024-08-13_23:24:55.185355_tnRN 2024-08-13_23:24:55.185361_hmef 2024-08-13_23:24:55.185367_OYsE 2024-08-13_23:24:55.185374_vHUm 2024-08-13_23:24:55.185381_nwqb 2024-08-13_23:24:55.185387_Tdhy 2024-08-13_23:24:55.185393_mcrM

redfin-30

Percentile	`9017c35`	`5beb95a`	Diff	Significant (?)
p10	6.12 ±1 ms	6.18 ±1 ms	+55.5 μs (+0.9%)	NO
p25	6.58 ±2 ms	6.70 ±1 ms	+125 μs (+1.9%)	NO
p50	7.26 ±3 ms	7.70 ±2 ms	+448 μs (+6.2%)	NO
p75	7.93 ±4 ms	8.76 ±4 ms	+834 μs (+10.5%)	NO
p90	8.57 ±4 ms	10.1 ±5 ms	+1.55 ms (+18.0%)	NO

20 test runs in comparison

Commit	Test Runs
`9017c35`	2024-08-12_21:34:34.943821_zmot 2024-08-12_21:34:34.943866_OhxB 2024-08-12_21:34:34.943878_nLGG 2024-08-12_21:34:34.943886_GyZj 2024-08-12_21:34:34.943893_GaKs 2024-08-12_21:34:34.943900_uMXJ 2024-08-12_21:34:34.943907_iYXd 2024-08-12_21:34:34.943913_zpyn 2024-08-12_21:34:34.943920_rTIf 2024-08-12_21:34:34.943927_UKWy
`5beb95a`	2024-08-13_23:24:55.185292_EUSZ 2024-08-13_23:24:55.185339_FPcy 2024-08-13_23:24:55.185348_xIIP 2024-08-13_23:24:55.185355_tnRN 2024-08-13_23:24:55.185361_hmef 2024-08-13_23:24:55.185367_OYsE 2024-08-13_23:24:55.185374_vHUm 2024-08-13_23:24:55.185381_nwqb 2024-08-13_23:24:55.185387_Tdhy 2024-08-13_23:24:55.185393_mcrM

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`9017c35`	`5beb95a`	Diff	Significant (?)
p10	201 ±5 ms	214 ±24 ms	+12.9 ms (+6.4%)	NO
p25	207 ±6 ms	220 ±26 ms	+13.1 ms (+6.3%)	NO
p50	215 ±6 ms	229 ±29 ms	+14.4 ms (+6.7%)	NO
p75	222 ±5 ms	240 ±34 ms	+17.4 ms (+7.8%)	NO
p90	230 ±6 ms	253 ±36 ms	+22.3 ms (+9.7%)	NO

20 test runs in comparison

Commit	Test Runs
`9017c35`	2024-08-12_21:34:34.943821_zmot 2024-08-12_21:34:34.943866_OhxB 2024-08-12_21:34:34.943878_nLGG 2024-08-12_21:34:34.943886_GyZj 2024-08-12_21:34:34.943893_GaKs 2024-08-12_21:34:34.943900_uMXJ 2024-08-12_21:34:34.943907_iYXd 2024-08-12_21:34:34.943913_zpyn 2024-08-12_21:34:34.943920_rTIf 2024-08-12_21:34:34.943927_UKWy
`5beb95a`	2024-08-13_23:24:55.185292_EUSZ 2024-08-13_23:24:55.185339_FPcy 2024-08-13_23:24:55.185348_xIIP 2024-08-13_23:24:55.185355_tnRN 2024-08-13_23:24:55.185361_hmef 2024-08-13_23:24:55.185367_OYsE 2024-08-13_23:24:55.185374_vHUm 2024-08-13_23:24:55.185381_nwqb 2024-08-13_23:24:55.185387_Tdhy 2024-08-13_23:24:55.185393_mcrM

redfin-30

Percentile	`9017c35`	`5beb95a`	Diff	Significant (?)
p10	242 ±3 ms	265 ±5 ms	+23.1 ms (+9.6%)	MAYBE
p25	248 ±3 ms	271 ±5 ms	+23.7 ms (+9.6%)	MAYBE
p50	254 ±4 ms	278 ±7 ms	+24.4 ms (+9.6%)	MAYBE
p75	262 ±4 ms	288 ±7 ms	+26.3 ms (+10.1%)	MAYBE
p90	272 ±8 ms	303 ±12 ms	+31.0 ms (+11.4%)	NO

20 test runs in comparison

Commit	Test Runs
`9017c35`	2024-08-12_21:34:34.943821_zmot 2024-08-12_21:34:34.943866_OhxB 2024-08-12_21:34:34.943878_nLGG 2024-08-12_21:34:34.943886_GyZj 2024-08-12_21:34:34.943893_GaKs 2024-08-12_21:34:34.943900_uMXJ 2024-08-12_21:34:34.943907_iYXd 2024-08-12_21:34:34.943913_zpyn 2024-08-12_21:34:34.943920_rTIf 2024-08-12_21:34:34.943927_UKWy
`5beb95a`	2024-08-13_23:24:55.185292_EUSZ 2024-08-13_23:24:55.185339_FPcy 2024-08-13_23:24:55.185348_xIIP 2024-08-13_23:24:55.185355_tnRN 2024-08-13_23:24:55.185361_hmef 2024-08-13_23:24:55.185367_OYsE 2024-08-13_23:24:55.185374_vHUm 2024-08-13_23:24:55.185381_nwqb 2024-08-13_23:24:55.185387_Tdhy 2024-08-13_23:24:55.185393_mcrM

https://storage.googleapis.com/firebase-sdk-metric-reports/5h9wm3coSW/index.html

...ics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsController.java

github-actions · 2024-08-06T19:43:21Z

Unit Test Results

  8 files +  4   8 suites +4 26s ⏱️ +23s
22 tests - 28 22 ✔️ - 28 0 💤 ±0 0 ❌ ±0
44 runs - 56 44 ✔️ - 56 0 💤 ±0 0 ❌ ±0

Results for commit c4bdb31. ± Comparison against base commit 9017c35.

This pull request removes 50 and adds 22 tests. Note that renamed tests count towards both.

com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
com.google.firebase.vertexai.StreamingSnapshotTests ‑ long reply
com.google.firebase.vertexai.StreamingSnapshotTests ‑ malformed content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ prompt blocked for safety
com.google.firebase.vertexai.StreamingSnapshotTests ‑ quotes escaped
…

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…

♻️ This comment has been updated with latest results.

This reverts commit db42bae.

themiswang requested a review from mrober August 6, 2024 03:00

google-oss-bot added the do-not-merge/work-in-progress label Aug 6, 2024

google-oss-bot added the size/M label Aug 6, 2024

themiswang force-pushed the moreTaskToDiskWrite branch 2 times, most recently from 1b91c64 to 3632e38 Compare August 6, 2024 03:07

mrober reviewed Aug 6, 2024

View reviewed changes

...ics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsController.java Outdated Show resolved Hide resolved

mrober reviewed Aug 6, 2024

View reviewed changes

...ics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsController.java Show resolved Hide resolved

themiswang force-pushed the moreTaskToDiskWrite branch from 9d32d27 to aae872c Compare August 6, 2024 19:33

themiswang marked this pull request as ready for review August 6, 2024 19:36

google-oss-bot removed the do-not-merge/work-in-progress label Aug 6, 2024

mrober approved these changes Aug 13, 2024

View reviewed changes

themiswang added 3 commits August 13, 2024 11:29

move more jobs to disk write

39199d0

add precondition to reinforce the executrion on background thread

7036db5

fix unit tests

23bcd86

themiswang force-pushed the moreTaskToDiskWrite branch 5 times, most recently from 102cacf to c4bdb31 Compare August 13, 2024 21:26

fix merge conflict

54275a2

themiswang force-pushed the moreTaskToDiskWrite branch from c4bdb31 to 54275a2 Compare August 13, 2024 23:12

themiswang merged commit db42bae into main Aug 14, 2024
41 of 42 checks passed

themiswang deleted the moreTaskToDiskWrite branch August 14, 2024 02:46

mrober added a commit that referenced this pull request Aug 19, 2024

Revert "move more jobs to disk write (#6156)"

92fce90

This reverts commit db42bae.

firebase locked and limited conversation to collaborators Sep 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

move more jobs to disk write #6156

move more jobs to disk write #6156

Uh oh!

themiswang commented Aug 6, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Aug 6, 2024 •

edited

Loading

Uh oh!

google-oss-bot commented Aug 6, 2024

Uh oh!

google-oss-bot commented Aug 6, 2024 •

edited

Loading

`firebase-crashlytics`

Uh oh!

google-oss-bot commented Aug 6, 2024 •

edited

Loading

`firebase-crashlytics`

Uh oh!

google-oss-bot commented Aug 6, 2024 •

edited

Loading

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 6, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

move more jobs to disk write #6156

move more jobs to disk write #6156

Uh oh!

Conversation

themiswang commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release note changes

Uh oh!

google-oss-bot commented Aug 6, 2024

Uh oh!

google-oss-bot commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-crashlytics

Test Logs

Uh oh!

google-oss-bot commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-crashlytics

Test Logs

Uh oh!

google-oss-bot commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-rc

fire-sessions

timeToInitialDisplay

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Uh oh!

Uh oh!

themiswang commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Aug 6, 2024 •

edited

Loading

google-oss-bot commented Aug 6, 2024 •

edited

Loading

Coverage Report ¹

`firebase-crashlytics`

google-oss-bot commented Aug 6, 2024 •

edited

Loading

Size Report ¹

`firebase-crashlytics`

google-oss-bot commented Aug 6, 2024 •

edited

Loading

Startup Time Report ¹

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`

github-actions bot commented Aug 6, 2024 •

edited

Loading