Skip to content

update vertex javadocs to match what's live #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

davidmotson
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/GenerationConfig.html	2024-08-01 18:37:30.672455161 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/GenerationConfig.html	2024-08-01 18:35:27.743356257 +0000
@@ -69,14 +69,14 @@
             <td><code>final <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/GenerationConfig.html#responseMimeType()">responseMimeType</a></code></div>
-              <p>Response type for generated candidate text.</p>
+              <p>Response MIME type for the generated candidate text.</p>
             </td>
           </tr>
           <tr>
             <td><code>final <a href="/docs/reference/android/com/google/firebase/vertexai/type/Schema.html">Schema</a>&lt;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> ?&gt;</code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/GenerationConfig.html#responseSchema()">responseSchema</a></code></div>
-              <p>A schema that the response must adhere to, used with the <code>application/json</code> mimeType.</p>
+              <p>A schema that the response must adhere to, used with the <code>application/json</code> MINE type.</p>
             </td>
           </tr>
           <tr>
@@ -125,12 +125,12 @@
       <div class="api-item"><a name="getResponseMimeType()"></a><a name="setResponseMimeType()"></a><a name="getResponseMimeType--"></a><a name="setResponseMimeType--"></a>
         <h3 class="api-name" id="responseMimeType()">responseMimeType</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/GenerationConfig.html#responseMimeType()">responseMimeType</a></pre>
-        <p>Response type for generated candidate text. See the <a href="https://cloud.google.com/vertex-ai/docs/reference/rest/v1beta1/GenerationConfig">vertex docs</a> for a list of supported types.</p>
+        <p>Response MIME type for the generated candidate text. For a list of supported response MIME types, see the <a href="https://cloud.google.com/vertex-ai/docs/reference/rest/v1beta1/GenerationConfig#FIELDS.response_mime_type">Vertex AI documentation</a> for a list of supported types.</p>
       </div>
       <div class="api-item"><a name="getResponseSchema()"></a><a name="setResponseSchema()"></a><a name="getResponseSchema--"></a><a name="setResponseSchema--"></a>
         <h3 class="api-name" id="responseSchema()">responseSchema</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/Schema.html">Schema</a>&lt;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> ?&gt;&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/GenerationConfig.html#responseSchema()">responseSchema</a></pre>
-        <p>A schema that the response must adhere to, used with the <code>application/json</code> mimeType.</p>
+        <p>A schema that the response must adhere to, used with the <code>application/json</code> MINE type.</p>
       </div>
       <div class="api-item"><a name="getStopSequences()"></a><a name="setStopSequences()"></a><a name="getStopSequences--"></a><a name="setStopSequences--"></a>
         <h3 class="api-name" id="stopSequences()">stopSequences</h3>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/GenerationConfig.html	2024-08-01 18:37:30.664455092 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/GenerationConfig.html	2024-08-01 18:35:27.735356180 +0000
@@ -86,14 +86,14 @@
             <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?</code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/GenerationConfig.html#responseMimeType()">responseMimeType</a></code></div>
-              <p>Response type for generated candidate text.</p>
+              <p>Response MIME type for the generated candidate text.</p>
             </td>
           </tr>
           <tr>
             <td><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Schema.html">Schema</a>&lt;*&gt;?</code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/GenerationConfig.html#responseSchema()">responseSchema</a></code></div>
-              <p>A schema that the response must adhere to, used with the <code>application/json</code> mimeType.</p>
+              <p>A schema that the response must adhere to, used with the <code>application/json</code> MINE type.</p>
             </td>
           </tr>
           <tr>
@@ -151,12 +151,12 @@
       <div class="api-item"><a name="getResponseMimeType()"></a><a name="setResponseMimeType()"></a><a name="getResponseMimeType--"></a><a name="setResponseMimeType--"></a>
         <h3 class="api-name" id="responseMimeType()">responseMimeType</h3>
         <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/GenerationConfig.html#responseMimeType()">responseMimeType</a>:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?</pre>
-        <p>Response type for generated candidate text. See the <a href="https://cloud.google.com/vertex-ai/docs/reference/rest/v1beta1/GenerationConfig">vertex docs</a> for a list of supported types.</p>
+        <p>Response MIME type for the generated candidate text. For a list of supported response MIME types, see the <a href="https://cloud.google.com/vertex-ai/docs/reference/rest/v1beta1/GenerationConfig#FIELDS.response_mime_type">Vertex AI documentation</a> for a list of supported types.</p>
       </div>
       <div class="api-item"><a name="getResponseSchema()"></a><a name="setResponseSchema()"></a><a name="getResponseSchema--"></a><a name="setResponseSchema--"></a>
         <h3 class="api-name" id="responseSchema()">responseSchema</h3>
         <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/GenerationConfig.html#responseSchema()">responseSchema</a>:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Schema.html">Schema</a>&lt;*&gt;?</pre>
-        <p>A schema that the response must adhere to, used with the <code>application/json</code> mimeType.</p>
+        <p>A schema that the response must adhere to, used with the <code>application/json</code> MINE type.</p>
       </div>
       <div class="api-item"><a name="getStopSequences()"></a><a name="setStopSequences()"></a><a name="getStopSequences--"></a><a name="setStopSequences--"></a>
         <h3 class="api-name" id="stopSequences()">stopSequences</h3>

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 1, 2024

@VinayGuthal VinayGuthal self-requested a review August 1, 2024 18:28
@davidmotson davidmotson enabled auto-merge (squash) August 1, 2024 18:29
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Unit Test Results

    4 files   -   4      4 suites   - 4   3s ⏱️ -23s
  50 tests +28    50 ✔️ +28  0 💤 ±0  0 ±0 
100 runs  +56  100 ✔️ +56  0 💤 ±0  0 ±0 

Results for commit 99d9eb5. ± Comparison against base commit 99a9d93.

This pull request removes 22 and adds 50 tests. Note that renamed tests count towards both.
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
com.google.firebase.vertexai.StreamingSnapshotTests ‑ long reply
com.google.firebase.vertexai.StreamingSnapshotTests ‑ malformed content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ prompt blocked for safety
com.google.firebase.vertexai.StreamingSnapshotTests ‑ quotes escaped
…

♻️ This comment has been updated with latest results.

@davidmotson davidmotson merged commit 0605925 into main Aug 1, 2024
28 of 30 checks passed
@davidmotson davidmotson deleted the davidmotson.vertex_docs branch August 1, 2024 18:37
@google-oss-bot
Copy link
Contributor

@firebase firebase locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants