Skip to content

Add tests for internal apis used by development platform plugins #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Jul 31, 2024

Add test cases for internal apis used by development platform plugins so we don't break them by accident during refactoring.

We should consider making the internal api more explicit.

Copy link
Contributor

github-actions bot commented Jul 31, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@mrober mrober enabled auto-merge (squash) July 31, 2024 14:40
@google-oss-bot
Copy link
Contributor

Copy link
Contributor

Unit Test Results

  8 files  ±0    8 suites  ±0   26s ⏱️ -1s
22 tests ±0  22 ✔️ ±0  0 💤 ±0  0 ±0 
44 runs  ±0  44 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 90ae712. ± Comparison against base commit 10fe142.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (10fe142)Merge (d465841)Diff
    aar415 kB415 kB-3 B (-0.0%)
    apk (release)5.85 MB5.85 MB-8 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RFFeCFQf5P.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentile10fe142d465841DiffSignificant (?)
    p1013.8 ±3 ms11.7 ±3 ms-2.09 ms (-15.1%)NO
    p2514.6 ±3 ms12.4 ±3 ms-2.16 ms (-14.8%)NO
    p5015.7 ±4 ms13.3 ±3 ms-2.43 ms (-15.5%)NO
    p7517.1 ±4 ms14.7 ±3 ms-2.37 ms (-13.8%)NO
    p9018.9 ±4 ms16.5 ±3 ms-2.38 ms (-12.6%)NO

    20 test runs in comparison
    CommitTest Runs
    10fe142
    • 2024-07-30_18:18:22.927144_kyIS
    • 2024-07-30_18:18:22.927201_fnEg
    • 2024-07-30_18:18:22.927215_hiov
    • 2024-07-30_18:18:22.927224_xPCo
    • 2024-07-30_18:18:22.927231_nxZX
    • 2024-07-30_18:18:22.927239_oZKl
    • 2024-07-30_18:18:22.927246_CLVW
    • 2024-07-30_18:18:22.927252_gUpy
    • 2024-07-30_18:18:22.927259_pPQX
    • 2024-07-30_18:18:22.927265_ENOO
    d465841
    • 2024-07-31_14:50:47.341530_aXkG
    • 2024-07-31_14:50:47.341569_tUNj
    • 2024-07-31_14:50:47.341581_hnSD
    • 2024-07-31_14:50:47.341590_RnFi
    • 2024-07-31_14:50:47.341599_eDVC
    • 2024-07-31_14:50:47.341607_IANG
    • 2024-07-31_14:50:47.341615_IJgY
    • 2024-07-31_14:50:47.341621_pbrh
    • 2024-07-31_14:50:47.341628_JkIZ
    • 2024-07-31_14:50:47.341635_kUZD
    redfin-30
    Percentile10fe142d465841DiffSignificant (?)
    p1013.9 ±3 ms14.0 ±3 ms+86.6 μs (+0.6%)NO
    p2514.7 ±3 ms14.8 ±3 ms+72.4 μs (+0.5%)NO
    p5016.0 ±4 ms15.9 ±3 ms-24.5 μs (-0.2%)NO
    p7517.5 ±5 ms17.6 ±4 ms+117 μs (+0.7%)NO
    p9019.6 ±5 ms20.9 ±7 ms+1.33 ms (+6.8%)NO

    20 test runs in comparison
    CommitTest Runs
    10fe142
    • 2024-07-30_18:18:22.927144_kyIS
    • 2024-07-30_18:18:22.927201_fnEg
    • 2024-07-30_18:18:22.927215_hiov
    • 2024-07-30_18:18:22.927224_xPCo
    • 2024-07-30_18:18:22.927231_nxZX
    • 2024-07-30_18:18:22.927239_oZKl
    • 2024-07-30_18:18:22.927246_CLVW
    • 2024-07-30_18:18:22.927252_gUpy
    • 2024-07-30_18:18:22.927259_pPQX
    • 2024-07-30_18:18:22.927265_ENOO
    d465841
    • 2024-07-31_14:50:47.341530_aXkG
    • 2024-07-31_14:50:47.341569_tUNj
    • 2024-07-31_14:50:47.341581_hnSD
    • 2024-07-31_14:50:47.341590_RnFi
    • 2024-07-31_14:50:47.341599_eDVC
    • 2024-07-31_14:50:47.341607_IANG
    • 2024-07-31_14:50:47.341615_IJgY
    • 2024-07-31_14:50:47.341621_pbrh
    • 2024-07-31_14:50:47.341628_JkIZ
    • 2024-07-31_14:50:47.341635_kUZD
  • fire-rc

    DeviceStatisticsDistributions
    oriole-32
    Percentile10fe142d465841DiffSignificant (?)
    p10306 ±530 μs126 ±133 μs-180 μs (-58.9%)NO
    p25325 ±549 μs134 ±145 μs-191 μs (-58.8%)NO
    p50362 ±585 μs147 ±167 μs-214 μs (-59.2%)NO
    p75432 ±707 μs188 ±234 μs-244 μs (-56.4%)NO
    p90533 ±826 μs238 ±290 μs-295 μs (-55.3%)NO

    20 test runs in comparison
    CommitTest Runs
    10fe142
    • 2024-07-30_18:18:22.927144_kyIS
    • 2024-07-30_18:18:22.927201_fnEg
    • 2024-07-30_18:18:22.927215_hiov
    • 2024-07-30_18:18:22.927224_xPCo
    • 2024-07-30_18:18:22.927231_nxZX
    • 2024-07-30_18:18:22.927239_oZKl
    • 2024-07-30_18:18:22.927246_CLVW
    • 2024-07-30_18:18:22.927252_gUpy
    • 2024-07-30_18:18:22.927259_pPQX
    • 2024-07-30_18:18:22.927265_ENOO
    d465841
    • 2024-07-31_14:50:47.341530_aXkG
    • 2024-07-31_14:50:47.341569_tUNj
    • 2024-07-31_14:50:47.341581_hnSD
    • 2024-07-31_14:50:47.341590_RnFi
    • 2024-07-31_14:50:47.341599_eDVC
    • 2024-07-31_14:50:47.341607_IANG
    • 2024-07-31_14:50:47.341615_IJgY
    • 2024-07-31_14:50:47.341621_pbrh
    • 2024-07-31_14:50:47.341628_JkIZ
    • 2024-07-31_14:50:47.341635_kUZD
    redfin-30
    Percentile10fe142d465841DiffSignificant (?)
    p10309 ±287 μs425 ±448 μs+116 μs (+37.7%)NO
    p25369 ±361 μs522 ±531 μs+152 μs (+41.2%)NO
    p50469 ±503 μs680 ±694 μs+211 μs (+45.0%)NO
    p75579 ±615 μs854 ±886 μs+275 μs (+47.6%)NO
    p90740 ±785 μs1.10 ±1 ms+361 μs (+48.8%)NO

    20 test runs in comparison
    CommitTest Runs
    10fe142
    • 2024-07-30_18:18:22.927144_kyIS
    • 2024-07-30_18:18:22.927201_fnEg
    • 2024-07-30_18:18:22.927215_hiov
    • 2024-07-30_18:18:22.927224_xPCo
    • 2024-07-30_18:18:22.927231_nxZX
    • 2024-07-30_18:18:22.927239_oZKl
    • 2024-07-30_18:18:22.927246_CLVW
    • 2024-07-30_18:18:22.927252_gUpy
    • 2024-07-30_18:18:22.927259_pPQX
    • 2024-07-30_18:18:22.927265_ENOO
    d465841
    • 2024-07-31_14:50:47.341530_aXkG
    • 2024-07-31_14:50:47.341569_tUNj
    • 2024-07-31_14:50:47.341581_hnSD
    • 2024-07-31_14:50:47.341590_RnFi
    • 2024-07-31_14:50:47.341599_eDVC
    • 2024-07-31_14:50:47.341607_IANG
    • 2024-07-31_14:50:47.341615_IJgY
    • 2024-07-31_14:50:47.341621_pbrh
    • 2024-07-31_14:50:47.341628_JkIZ
    • 2024-07-31_14:50:47.341635_kUZD
  • fire-sessions

    DeviceStatisticsDistributions
    oriole-32
    Percentile10fe142d465841DiffSignificant (?)
    p102.30 ±0.2 ms2.76 ±0.6 ms+460 μs (+20.0%)NO
    p252.44 ±0.2 ms2.96 ±0.7 ms+516 μs (+21.1%)NO
    p502.70 ±0.3 ms3.37 ±0.7 ms+663 μs (+24.5%)NO
    p753.12 ±0.4 ms3.99 ±0.9 ms+865 μs (+27.7%)NO
    p903.73 ±0.7 ms4.87 ±1 ms+1.14 ms (+30.5%)NO

    20 test runs in comparison
    CommitTest Runs
    10fe142
    • 2024-07-30_18:18:22.927144_kyIS
    • 2024-07-30_18:18:22.927201_fnEg
    • 2024-07-30_18:18:22.927215_hiov
    • 2024-07-30_18:18:22.927224_xPCo
    • 2024-07-30_18:18:22.927231_nxZX
    • 2024-07-30_18:18:22.927239_oZKl
    • 2024-07-30_18:18:22.927246_CLVW
    • 2024-07-30_18:18:22.927252_gUpy
    • 2024-07-30_18:18:22.927259_pPQX
    • 2024-07-30_18:18:22.927265_ENOO
    d465841
    • 2024-07-31_14:50:47.341530_aXkG
    • 2024-07-31_14:50:47.341569_tUNj
    • 2024-07-31_14:50:47.341581_hnSD
    • 2024-07-31_14:50:47.341590_RnFi
    • 2024-07-31_14:50:47.341599_eDVC
    • 2024-07-31_14:50:47.341607_IANG
    • 2024-07-31_14:50:47.341615_IJgY
    • 2024-07-31_14:50:47.341621_pbrh
    • 2024-07-31_14:50:47.341628_JkIZ
    • 2024-07-31_14:50:47.341635_kUZD
    redfin-30
    Percentile10fe142d465841DiffSignificant (?)
    p105.90 ±1 ms6.30 ±2 ms+399 μs (+6.8%)NO
    p256.39 ±2 ms6.81 ±2 ms+421 μs (+6.6%)NO
    p507.09 ±2 ms7.75 ±3 ms+653 μs (+9.2%)NO
    p757.82 ±3 ms9.10 ±4 ms+1.28 ms (+16.4%)NO
    p908.66 ±4 ms10.8 ±6 ms+2.16 ms (+24.9%)NO

    20 test runs in comparison
    CommitTest Runs
    10fe142
    • 2024-07-30_18:18:22.927144_kyIS
    • 2024-07-30_18:18:22.927201_fnEg
    • 2024-07-30_18:18:22.927215_hiov
    • 2024-07-30_18:18:22.927224_xPCo
    • 2024-07-30_18:18:22.927231_nxZX
    • 2024-07-30_18:18:22.927239_oZKl
    • 2024-07-30_18:18:22.927246_CLVW
    • 2024-07-30_18:18:22.927252_gUpy
    • 2024-07-30_18:18:22.927259_pPQX
    • 2024-07-30_18:18:22.927265_ENOO
    d465841
    • 2024-07-31_14:50:47.341530_aXkG
    • 2024-07-31_14:50:47.341569_tUNj
    • 2024-07-31_14:50:47.341581_hnSD
    • 2024-07-31_14:50:47.341590_RnFi
    • 2024-07-31_14:50:47.341599_eDVC
    • 2024-07-31_14:50:47.341607_IANG
    • 2024-07-31_14:50:47.341615_IJgY
    • 2024-07-31_14:50:47.341621_pbrh
    • 2024-07-31_14:50:47.341628_JkIZ
    • 2024-07-31_14:50:47.341635_kUZD
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile10fe142d465841DiffSignificant (?)
    p10202 ±5 ms207 ±3 ms+5.27 ms (+2.6%)NO
    p25207 ±4 ms212 ±3 ms+5.20 ms (+2.5%)NO
    p50215 ±5 ms220 ±3 ms+5.16 ms (+2.4%)NO
    p75222 ±5 ms229 ±4 ms+6.99 ms (+3.1%)NO
    p90231 ±6 ms240 ±6 ms+8.51 ms (+3.7%)NO

    20 test runs in comparison
    CommitTest Runs
    10fe142
    • 2024-07-30_18:18:22.927144_kyIS
    • 2024-07-30_18:18:22.927201_fnEg
    • 2024-07-30_18:18:22.927215_hiov
    • 2024-07-30_18:18:22.927224_xPCo
    • 2024-07-30_18:18:22.927231_nxZX
    • 2024-07-30_18:18:22.927239_oZKl
    • 2024-07-30_18:18:22.927246_CLVW
    • 2024-07-30_18:18:22.927252_gUpy
    • 2024-07-30_18:18:22.927259_pPQX
    • 2024-07-30_18:18:22.927265_ENOO
    d465841
    • 2024-07-31_14:50:47.341530_aXkG
    • 2024-07-31_14:50:47.341569_tUNj
    • 2024-07-31_14:50:47.341581_hnSD
    • 2024-07-31_14:50:47.341590_RnFi
    • 2024-07-31_14:50:47.341599_eDVC
    • 2024-07-31_14:50:47.341607_IANG
    • 2024-07-31_14:50:47.341615_IJgY
    • 2024-07-31_14:50:47.341621_pbrh
    • 2024-07-31_14:50:47.341628_JkIZ
    • 2024-07-31_14:50:47.341635_kUZD
    redfin-30
    Percentile10fe142d465841DiffSignificant (?)
    p10244 ±6 ms267 ±6 ms+22.3 ms (+9.1%)MAYBE
    p25250 ±6 ms273 ±7 ms+23.0 ms (+9.2%)MAYBE
    p50256 ±7 ms281 ±8 ms+24.5 ms (+9.5%)MAYBE
    p75264 ±8 ms293 ±13 ms+29.3 ms (+11.1%)NO
    p90275 ±7 ms316 ±23 ms+41.2 ms (+15.0%)NO

    20 test runs in comparison
    CommitTest Runs
    10fe142
    • 2024-07-30_18:18:22.927144_kyIS
    • 2024-07-30_18:18:22.927201_fnEg
    • 2024-07-30_18:18:22.927215_hiov
    • 2024-07-30_18:18:22.927224_xPCo
    • 2024-07-30_18:18:22.927231_nxZX
    • 2024-07-30_18:18:22.927239_oZKl
    • 2024-07-30_18:18:22.927246_CLVW
    • 2024-07-30_18:18:22.927252_gUpy
    • 2024-07-30_18:18:22.927259_pPQX
    • 2024-07-30_18:18:22.927265_ENOO
    d465841
    • 2024-07-31_14:50:47.341530_aXkG
    • 2024-07-31_14:50:47.341569_tUNj
    • 2024-07-31_14:50:47.341581_hnSD
    • 2024-07-31_14:50:47.341590_RnFi
    • 2024-07-31_14:50:47.341599_eDVC
    • 2024-07-31_14:50:47.341607_IANG
    • 2024-07-31_14:50:47.341615_IJgY
    • 2024-07-31_14:50:47.341621_pbrh
    • 2024-07-31_14:50:47.341628_JkIZ
    • 2024-07-31_14:50:47.341635_kUZD

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SwGNCcbHOm/index.html

@mrober mrober merged commit d0fea0e into main Jul 31, 2024
46 checks passed
@mrober mrober deleted the crashlytics-dev-platform-tests branch July 31, 2024 19:29
@firebase firebase locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants