Move log and non-fatal persistence to disk write worker #6133

themiswang · 2024-07-29T19:51:55Z

Other metadata persistence is already on the right work from the previous pr #6120

Move log and non-fatal persistence to disk write worker
Refine unit tests
Remove unused functions and interface

github-actions · 2024-07-29T19:52:09Z

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

google-oss-bot · 2024-07-29T19:52:36Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

...ashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsCore.java

google-oss-bot · 2024-07-29T19:56:01Z

Coverage Report ¹

Affected Products

firebase-crashlytics
Overall coverage changed from 11.16% (c928402) to 11.17% (2209557) by +0.01%.
Filename Base (c928402) Merge (2209557) Diff
CrashlyticsCore.java 0.62% 0.61% -0.01%
SessionReportingCoordinator.java 42.11% 42.44% +0.34%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/PqNWMTaiup.html

github-actions · 2024-07-29T20:00:49Z

Unit Test Results

  8 files -   56   8 suites - 56 28s ⏱️ - 5m 34s
22 tests - 464 22 ✔️ - 464 0 💤 ±0 0 ❌ ±0
44 runs - 934 44 ✔️ - 934 0 💤 ±0 0 ❌ ±0

Results for commit 6ef3aa9. ± Comparison against base commit c928402.

This pull request removes 486 and adds 22 tests. Note that renamed tests count towards both.

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[24]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[22]
…

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2024-07-29T20:01:23Z

Size Report ¹

Affected Products

firebase-crashlytics
Type Base (c928402) Merge (2209557) Diff
aar 415 kB 415 kB -262 B (-0.1%)
apk (aggressive) 697 kB 697 kB +4 B (+0.0%)
apk (release) 5.85 MB 5.85 MB +568 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/oxHNG6yvs8.html

google-oss-bot · 2024-07-29T20:20:09Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (c928402) and the CI merge commit (2209557)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- c928402: https://storage.googleapis.com/firebase-sdk-metric-reports/3WHDvKPWS2/index.html
- 2209557: https://storage.googleapis.com/firebase-sdk-metric-reports/QO1jI0rTyG/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`c928402`	`2209557`	Diff	Significant (?)
p10	9.99 ±0.7 ms	11.9 ±3 ms	+1.94 ms (+19.4%)	NO
p25	10.6 ±0.7 ms	12.6 ±3 ms	+2.03 ms (+19.2%)	NO
p50	11.5 ±1 ms	13.6 ±3 ms	+2.15 ms (+18.7%)	NO
p75	12.7 ±1 ms	14.8 ±3 ms	+2.17 ms (+17.1%)	NO
p90	14.2 ±1 ms	16.4 ±3 ms	+2.23 ms (+15.7%)	NO

20 test runs in comparison

Commit	Test Runs
`c928402`	2024-07-30_16:20:34.487437_OOkJ 2024-07-30_16:20:34.487481_UheW 2024-07-30_16:20:34.487490_DZzt 2024-07-30_16:20:34.487497_ccdb 2024-07-30_16:20:34.487504_lVDy 2024-07-30_16:20:34.487511_YnNb 2024-07-30_16:20:34.487517_rTzq 2024-07-30_16:20:34.487523_bVit 2024-07-30_16:20:34.487529_GHyb 2024-07-30_16:20:34.487536_yOPj
`2209557`	2024-07-30_17:59:37.833659_ccPo 2024-07-30_17:59:37.833703_WqrU 2024-07-30_17:59:37.833713_sEoA 2024-07-30_17:59:37.833721_RZYA 2024-07-30_17:59:37.833729_Hnjz 2024-07-30_17:59:37.833735_zAcj 2024-07-30_17:59:37.833742_bHTm 2024-07-30_17:59:37.833749_CeNC 2024-07-30_17:59:37.833755_zKDB 2024-07-30_17:59:37.833762_qhEE

redfin-30

Percentile	`c928402`	`2209557`	Diff	Significant (?)
p10	16.2 ±5 ms	16.0 ±4 ms	-222 μs (-1.4%)	NO
p25	17.3 ±6 ms	17.0 ±5 ms	-250 μs (-1.4%)	NO
p50	18.7 ±7 ms	18.4 ±5 ms	-340 μs (-1.8%)	NO
p75	20.6 ±7 ms	20.2 ±6 ms	-344 μs (-1.7%)	NO
p90	23.1 ±9 ms	23.4 ±6 ms	+266 μs (+1.2%)	NO

20 test runs in comparison

Commit	Test Runs
`c928402`	2024-07-30_16:20:34.487437_OOkJ 2024-07-30_16:20:34.487481_UheW 2024-07-30_16:20:34.487490_DZzt 2024-07-30_16:20:34.487497_ccdb 2024-07-30_16:20:34.487504_lVDy 2024-07-30_16:20:34.487511_YnNb 2024-07-30_16:20:34.487517_rTzq 2024-07-30_16:20:34.487523_bVit 2024-07-30_16:20:34.487529_GHyb 2024-07-30_16:20:34.487536_yOPj
`2209557`	2024-07-30_17:59:37.833659_ccPo 2024-07-30_17:59:37.833703_WqrU 2024-07-30_17:59:37.833713_sEoA 2024-07-30_17:59:37.833721_RZYA 2024-07-30_17:59:37.833729_Hnjz 2024-07-30_17:59:37.833735_zAcj 2024-07-30_17:59:37.833742_bHTm 2024-07-30_17:59:37.833749_CeNC 2024-07-30_17:59:37.833755_zKDB 2024-07-30_17:59:37.833762_qhEE

`fire-rc`

Device Statistics Distributions

oriole-32

Percentile	`c928402`	`2209557`	Diff	Significant (?)
p10	413 ±595 μs	283 ±478 μs	-130 μs (-31.5%)	NO
p25	443 ±640 μs	301 ±511 μs	-142 μs (-32.1%)	NO
p50	508 ±738 μs	332 ±552 μs	-176 μs (-34.6%)	NO
p75	598 ±858 μs	392 ±655 μs	-206 μs (-34.5%)	NO
p90	778 ±1120 μs	521 ±886 μs	-258 μs (-33.1%)	NO

20 test runs in comparison

Commit	Test Runs
`c928402`	2024-07-30_16:20:34.487437_OOkJ 2024-07-30_16:20:34.487481_UheW 2024-07-30_16:20:34.487490_DZzt 2024-07-30_16:20:34.487497_ccdb 2024-07-30_16:20:34.487504_lVDy 2024-07-30_16:20:34.487511_YnNb 2024-07-30_16:20:34.487517_rTzq 2024-07-30_16:20:34.487523_bVit 2024-07-30_16:20:34.487529_GHyb 2024-07-30_16:20:34.487536_yOPj
`2209557`	2024-07-30_17:59:37.833659_ccPo 2024-07-30_17:59:37.833703_WqrU 2024-07-30_17:59:37.833713_sEoA 2024-07-30_17:59:37.833721_RZYA 2024-07-30_17:59:37.833729_Hnjz 2024-07-30_17:59:37.833735_zAcj 2024-07-30_17:59:37.833742_bHTm 2024-07-30_17:59:37.833749_CeNC 2024-07-30_17:59:37.833755_zKDB 2024-07-30_17:59:37.833762_qhEE

redfin-30

Percentile	`c928402`	`2209557`	Diff	Significant (?)
p10	536 ±654 μs	248 ±215 μs	-287 μs (-53.6%)	NO
p25	632 ±782 μs	272 ±255 μs	-360 μs (-56.9%)	NO
p50	767 ±943 μs	338 ±398 μs	-429 μs (-55.9%)	NO
p75	922 ±1125 μs	409 ±490 μs	-513 μs (-55.6%)	NO
p90	1.20 ±2 ms	583 ±823 μs	-620 μs (-51.5%)	NO

20 test runs in comparison

Commit	Test Runs
`c928402`	2024-07-30_16:20:34.487437_OOkJ 2024-07-30_16:20:34.487481_UheW 2024-07-30_16:20:34.487490_DZzt 2024-07-30_16:20:34.487497_ccdb 2024-07-30_16:20:34.487504_lVDy 2024-07-30_16:20:34.487511_YnNb 2024-07-30_16:20:34.487517_rTzq 2024-07-30_16:20:34.487523_bVit 2024-07-30_16:20:34.487529_GHyb 2024-07-30_16:20:34.487536_yOPj
`2209557`	2024-07-30_17:59:37.833659_ccPo 2024-07-30_17:59:37.833703_WqrU 2024-07-30_17:59:37.833713_sEoA 2024-07-30_17:59:37.833721_RZYA 2024-07-30_17:59:37.833729_Hnjz 2024-07-30_17:59:37.833735_zAcj 2024-07-30_17:59:37.833742_bHTm 2024-07-30_17:59:37.833749_CeNC 2024-07-30_17:59:37.833755_zKDB 2024-07-30_17:59:37.833762_qhEE

`fire-sessions`

Device Statistics Distributions

oriole-32

Percentile	`c928402`	`2209557`	Diff	Significant (?)
p10	2.94 ±0.7 ms	2.89 ±0.8 ms	-43.1 μs (-1.5%)	NO
p25	3.12 ±0.7 ms	3.06 ±0.9 ms	-63.9 μs (-2.0%)	NO
p50	3.43 ±0.8 ms	3.39 ±1 ms	-38.8 μs (-1.1%)	NO
p75	3.97 ±1 ms	3.90 ±1 ms	-73.1 μs (-1.8%)	NO
p90	4.81 ±1 ms	4.57 ±1 ms	-237 μs (-4.9%)	NO

20 test runs in comparison

Commit	Test Runs
`c928402`	2024-07-30_16:20:34.487437_OOkJ 2024-07-30_16:20:34.487481_UheW 2024-07-30_16:20:34.487490_DZzt 2024-07-30_16:20:34.487497_ccdb 2024-07-30_16:20:34.487504_lVDy 2024-07-30_16:20:34.487511_YnNb 2024-07-30_16:20:34.487517_rTzq 2024-07-30_16:20:34.487523_bVit 2024-07-30_16:20:34.487529_GHyb 2024-07-30_16:20:34.487536_yOPj
`2209557`	2024-07-30_17:59:37.833659_ccPo 2024-07-30_17:59:37.833703_WqrU 2024-07-30_17:59:37.833713_sEoA 2024-07-30_17:59:37.833721_RZYA 2024-07-30_17:59:37.833729_Hnjz 2024-07-30_17:59:37.833735_zAcj 2024-07-30_17:59:37.833742_bHTm 2024-07-30_17:59:37.833749_CeNC 2024-07-30_17:59:37.833755_zKDB 2024-07-30_17:59:37.833762_qhEE

redfin-30

Percentile	`c928402`	`2209557`	Diff	Significant (?)
p10	6.07 ±2 ms	6.19 ±2 ms	+129 μs (+2.1%)	NO
p25	6.54 ±2 ms	6.64 ±2 ms	+99.8 μs (+1.5%)	NO
p50	7.31 ±3 ms	7.37 ±3 ms	+60.3 μs (+0.8%)	NO
p75	8.53 ±5 ms	8.30 ±4 ms	-223 μs (-2.6%)	NO
p90	9.56 ±6 ms	9.41 ±5 ms	-151 μs (-1.6%)	NO

20 test runs in comparison

Commit	Test Runs
`c928402`	2024-07-30_16:20:34.487437_OOkJ 2024-07-30_16:20:34.487481_UheW 2024-07-30_16:20:34.487490_DZzt 2024-07-30_16:20:34.487497_ccdb 2024-07-30_16:20:34.487504_lVDy 2024-07-30_16:20:34.487511_YnNb 2024-07-30_16:20:34.487517_rTzq 2024-07-30_16:20:34.487523_bVit 2024-07-30_16:20:34.487529_GHyb 2024-07-30_16:20:34.487536_yOPj
`2209557`	2024-07-30_17:59:37.833659_ccPo 2024-07-30_17:59:37.833703_WqrU 2024-07-30_17:59:37.833713_sEoA 2024-07-30_17:59:37.833721_RZYA 2024-07-30_17:59:37.833729_Hnjz 2024-07-30_17:59:37.833735_zAcj 2024-07-30_17:59:37.833742_bHTm 2024-07-30_17:59:37.833749_CeNC 2024-07-30_17:59:37.833755_zKDB 2024-07-30_17:59:37.833762_qhEE

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`c928402`	`2209557`	Diff	Significant (?)
p10	205 ±8 ms	206 ±8 ms	+1.55 ms (+0.8%)	NO
p25	211 ±10 ms	212 ±8 ms	+692 μs (+0.3%)	NO
p50	221 ±18 ms	219 ±9 ms	-2.30 ms (-1.0%)	NO
p75	230 ±21 ms	227 ±9.5 ms	-2.34 ms (-1.0%)	NO
p90	239 ±26 ms	236 ±9.8 ms	-2.81 ms (-1.2%)	NO

20 test runs in comparison

Commit	Test Runs
`c928402`	2024-07-30_16:20:34.487437_OOkJ 2024-07-30_16:20:34.487481_UheW 2024-07-30_16:20:34.487490_DZzt 2024-07-30_16:20:34.487497_ccdb 2024-07-30_16:20:34.487504_lVDy 2024-07-30_16:20:34.487511_YnNb 2024-07-30_16:20:34.487517_rTzq 2024-07-30_16:20:34.487523_bVit 2024-07-30_16:20:34.487529_GHyb 2024-07-30_16:20:34.487536_yOPj
`2209557`	2024-07-30_17:59:37.833659_ccPo 2024-07-30_17:59:37.833703_WqrU 2024-07-30_17:59:37.833713_sEoA 2024-07-30_17:59:37.833721_RZYA 2024-07-30_17:59:37.833729_Hnjz 2024-07-30_17:59:37.833735_zAcj 2024-07-30_17:59:37.833742_bHTm 2024-07-30_17:59:37.833749_CeNC 2024-07-30_17:59:37.833755_zKDB 2024-07-30_17:59:37.833762_qhEE

redfin-30

Percentile	`c928402`	`2209557`	Diff	Significant (?)
p10	252 ±15 ms	264 ±4 ms	+11.6 ms (+4.6%)	NO
p25	258 ±15 ms	270 ±5 ms	+11.6 ms (+4.5%)	NO
p50	264 ±16 ms	276 ±5 ms	+12.0 ms (+4.5%)	NO
p75	272 ±17 ms	285 ±6 ms	+12.5 ms (+4.6%)	NO
p90	286 ±19 ms	298 ±8 ms	+11.6 ms (+4.0%)	NO

20 test runs in comparison

Commit	Test Runs
`c928402`	2024-07-30_16:20:34.487437_OOkJ 2024-07-30_16:20:34.487481_UheW 2024-07-30_16:20:34.487490_DZzt 2024-07-30_16:20:34.487497_ccdb 2024-07-30_16:20:34.487504_lVDy 2024-07-30_16:20:34.487511_YnNb 2024-07-30_16:20:34.487517_rTzq 2024-07-30_16:20:34.487523_bVit 2024-07-30_16:20:34.487529_GHyb 2024-07-30_16:20:34.487536_yOPj
`2209557`	2024-07-30_17:59:37.833659_ccPo 2024-07-30_17:59:37.833703_WqrU 2024-07-30_17:59:37.833713_sEoA 2024-07-30_17:59:37.833721_RZYA 2024-07-30_17:59:37.833729_Hnjz 2024-07-30_17:59:37.833735_zAcj 2024-07-30_17:59:37.833742_bHTm 2024-07-30_17:59:37.833749_CeNC 2024-07-30_17:59:37.833755_zKDB 2024-07-30_17:59:37.833762_qhEE

https://storage.googleapis.com/firebase-sdk-metric-reports/1DphEWSael/index.html

...c/main/java/com/google/firebase/crashlytics/internal/common/SessionReportingCoordinator.java

This reverts commit 10fe142.

google-oss-bot added the do-not-merge/work-in-progress label Jul 29, 2024

themiswang requested a review from mrober July 29, 2024 19:51

themiswang marked this pull request as ready for review July 29, 2024 19:52

google-oss-bot removed the do-not-merge/work-in-progress label Jul 29, 2024

google-oss-bot added the size/L label Jul 29, 2024

themiswang commented Jul 29, 2024

View reviewed changes

...ashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsCore.java Outdated Show resolved Hide resolved

themiswang commented Jul 30, 2024

View reviewed changes

...c/main/java/com/google/firebase/crashlytics/internal/common/SessionReportingCoordinator.java Outdated Show resolved Hide resolved

themiswang added 2 commits July 30, 2024 13:47

move log and non-fatal presistence to disk write worker

2f347a1

address comments

6ef3aa9

themiswang force-pushed the userActionPersistence branch from 7ebc4d3 to 6ef3aa9 Compare July 30, 2024 17:47

mrober approved these changes Jul 30, 2024

View reviewed changes

themiswang merged commit 10fe142 into main Jul 30, 2024
41 of 42 checks passed

themiswang deleted the userActionPersistence branch July 30, 2024 18:06

mrober added a commit that referenced this pull request Aug 19, 2024

Revert "Move log and non-fatal persistence to disk write worker (#6133)"

a94ddbf

This reverts commit 10fe142.

firebase locked and limited conversation to collaborators Aug 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move log and non-fatal persistence to disk write worker #6133

Move log and non-fatal persistence to disk write worker #6133

Uh oh!

themiswang commented Jul 29, 2024

Uh oh!

github-actions bot commented Jul 29, 2024 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 29, 2024

Uh oh!

Uh oh!

google-oss-bot commented Jul 29, 2024 •

edited

Loading

`firebase-crashlytics`

Uh oh!

github-actions bot commented Jul 29, 2024 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 29, 2024 •

edited

Loading

`firebase-crashlytics`

Uh oh!

google-oss-bot commented Jul 29, 2024 •

edited

Loading

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Move log and non-fatal persistence to disk write worker #6133

Move log and non-fatal persistence to disk write worker #6133

Uh oh!

Conversation

themiswang commented Jul 29, 2024

Uh oh!

github-actions bot commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release note changes

Uh oh!

google-oss-bot commented Jul 29, 2024

Uh oh!

Uh oh!

google-oss-bot commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-crashlytics

Test Logs

Uh oh!

github-actions bot commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

google-oss-bot commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-crashlytics

Test Logs

Uh oh!

google-oss-bot commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-rc

fire-sessions

timeToInitialDisplay

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2024 •

edited

Loading

google-oss-bot commented Jul 29, 2024 •

edited

Loading

Coverage Report ¹

`firebase-crashlytics`

github-actions bot commented Jul 29, 2024 •

edited

Loading

google-oss-bot commented Jul 29, 2024 •

edited

Loading

Size Report ¹

`firebase-crashlytics`

google-oss-bot commented Jul 29, 2024 •

edited

Loading

Startup Time Report ¹

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`