Skip to content

VertexAI: update test cases to use full name of mock response files #6127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

tanzimfh
Copy link
Contributor

This will allow these files to be scanned by a coverage tool to be added to https://github.com/firebaseextended/vertexai-sdk-test-data.

Copy link
Contributor

github-actions bot commented Jul 26, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

Unit Test Results

    4 files  +    4      4 suites  +4   3s ⏱️ +3s
  50 tests +  50    50 ✔️ +  50  0 💤 ±0  0 ±0 
100 runs  +100  100 ✔️ +100  0 💤 ±0  0 ±0 

Results for commit dcae90c. ± Comparison against base commit 1b49171.

@google-oss-bot
Copy link
Contributor

@tanzimfh tanzimfh merged commit 0b026b2 into main Jul 26, 2024
31 of 32 checks passed
@tanzimfh tanzimfh deleted the tanzim/filenames branch July 26, 2024 15:40
@firebase firebase locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants