-
Notifications
You must be signed in to change notification settings - Fork 617
Convenient preconditions specific for Crashlytics concurrency #6125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
...lytics/src/main/java/com/google/firebase/crashlytics/internal/CrashlyticsPreconditions.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
/* | ||
* Copyright 2024 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.firebase.crashlytics.internal | ||
|
||
import android.os.Build | ||
import android.os.Looper | ||
import com.google.firebase.crashlytics.internal.CrashlyticsPreconditions.StrictLevel.ASSERT | ||
import com.google.firebase.crashlytics.internal.CrashlyticsPreconditions.StrictLevel.NONE | ||
import com.google.firebase.crashlytics.internal.CrashlyticsPreconditions.StrictLevel.THROW | ||
import com.google.firebase.crashlytics.internal.CrashlyticsPreconditions.StrictLevel.WARN | ||
|
||
/** | ||
* Convenient preconditions specific for Crashlytics concurrency. | ||
* | ||
* Use GMS Core's [com.google.android.gms.common.internal.Preconditions] for general preconditions. | ||
*/ | ||
internal object CrashlyticsPreconditions { | ||
private val threadName | ||
get() = Thread.currentThread().name | ||
|
||
// TODO(mrober): Make this a build time configuration. | ||
@JvmStatic var strictLevel: StrictLevel = NONE | ||
|
||
@JvmStatic | ||
fun checkMainThread() = | ||
checkThread(::isMainThread) { "Must be called on the main thread, was called on $threadName." } | ||
|
||
@JvmStatic | ||
fun checkBlockingThread() = | ||
checkThread(::isBlockingThread) { | ||
"Must be called on a blocking thread, was called on $threadName." | ||
} | ||
|
||
@JvmStatic | ||
fun checkBackgroundThread() = | ||
checkThread(::isBackgroundThread) { | ||
"Must be called on a background thread, was called on $threadName." | ||
} | ||
|
||
private fun isMainThread() = | ||
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { | ||
Looper.getMainLooper().isCurrentThread | ||
} else { | ||
Looper.getMainLooper() == Looper.myLooper() | ||
} | ||
|
||
private fun isBlockingThread() = threadName.contains("Firebase Blocking Thread #") | ||
|
||
// TODO(mrober): Remove the Crashlytics thread when fully migrated to Firebase common threads. | ||
private fun isBackgroundThread() = | ||
threadName.contains("Firebase Background Thread #") || | ||
threadName.contains("Crashlytics Exception Handler") | ||
|
||
private fun checkThread(isCorrectThread: () -> Boolean, failureMessage: () -> String) { | ||
if (strictLevel.level >= WARN.level && !isCorrectThread()) { | ||
Logger.getLogger().w(failureMessage()) | ||
assert(strictLevel.level < ASSERT.level, failureMessage) | ||
check(strictLevel.level < THROW.level, failureMessage) | ||
} | ||
} | ||
|
||
enum class StrictLevel(val level: Int) : Comparable<StrictLevel> { | ||
/** Do not check for violations. */ | ||
NONE(0), | ||
/** Log violations as warnings. */ | ||
WARN(1), | ||
/** Throw an exception on violation. */ | ||
THROW(2), | ||
/** Kill the process on violation. Useful for debugging. */ | ||
ASSERT(3), | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.