Skip to content

Fix m150 issues #6109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Fix m150 issues #6109

merged 2 commits into from
Jul 19, 2024

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Jul 17, 2024

Per b/353751840,

This fixes the issues that were causing tests to fail when trying to copy the changes into head. More specifically:

  • It suppresses a Kotlin Internal usage- as it's a false positive (they live under the same package, which is okay'd internally)
  • It adds a type to a Class usage- as this seems to be required at head

NO_RELEASE_CHANGE

@daymxn daymxn requested review from rlazo and davidmotson July 17, 2024 19:37
@daymxn daymxn self-assigned this Jul 17, 2024
Copy link
Contributor

github-actions bot commented Jul 17, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@daymxn daymxn changed the title Fix m150 copybara TAP failures Fix m150 copybara issues Jul 17, 2024
@rlazo rlazo changed the title Fix m150 copybara issues Fix m150 issues Jul 17, 2024
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (03c20fa) and merge commit (82ce612).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/APYiOmXBUZ.html

Copy link
Contributor

Unit Test Results

0 files   -      948  0 suites   - 948   0s ⏱️ - 34m 18s
0 tests  -   5 242  0 ✔️  -   5 211  0 💤  - 21  0  - 10 
0 runs   - 10 569  0 ✔️  - 10 517  0 💤  - 42  0  - 10 

Results for commit aef22f6. ± Comparison against base commit 03c20fa.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (03c20fa)Merge (82ce612)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-crashlytics

    TypeBase (03c20fa)Merge (82ce612)Diff
    aar?408 kB? (?)
    apk (aggressive)?695 kB? (?)
    apk (release)?5.84 MB? (?)
  • firebase-sessions

    TypeBase (03c20fa)Merge (82ce612)Diff
    aar?168 kB? (?)
    apk (aggressive)?560 kB? (?)
    apk (release)?5.52 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ch9qGIxFSU.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (82ce612) and the base commit (03c20fa) are not available.

No macrobenchmark data found for the base commit (03c20fa). Analysis for the CI merge commit (82ce612) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oigi8wgsNK/index.html

@daymxn daymxn merged commit 1c03d4b into main Jul 19, 2024
35 of 38 checks passed
@daymxn daymxn deleted the daymon-fix-m150-copybara branch July 19, 2024 17:33
@firebase firebase locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants