Retry topic subscription on quota errors using exponential backoff #6098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-messaging### {{messaging_longer}} version 24.0.1 {: #messaging_v24-0-1}
* {{changed}} Retry Topic Subscribe/Unsubscribe operations with exponential
backoff if they hit a quota error.
#### {{messaging_longer}} Kotlin extensions version 24.0.1 {: #messaging-ktx_v24-0-1}
The Kotlin extensions library transitively includes the updated
`firebase-messaging` library. The Kotlin extensions library has no additional
updates. |
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
Unit Test Results 64 files + 56 64 suites +56 6m 10s ⏱️ + 5m 45s Results for commit e8336b8. ± Comparison against base commit 26c8a5a. This pull request removes 22 and adds 486 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
gsakakihara
approved these changes
Jul 12, 2024
firebase-messaging/src/main/java/com/google/firebase/messaging/TopicsSubscriber.java
Outdated
Show resolved
Hide resolved
firebase-messaging/src/main/java/com/google/firebase/messaging/GmsRpc.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic subscription requests might hit a quota, but we can retry these failures with exponential backoff incase they are transient
Fixes #6032