Skip to content

Add Vertex AI unit tests #6090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 15, 2024
Merged

Add Vertex AI unit tests #6090

merged 6 commits into from
Jul 15, 2024

Conversation

tanzimfh
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

Unit Test Results

     954 files  +  4       954 suites  +4   35m 33s ⏱️ +11s
  5 246 tests +35    5 225 ✔️ +35  21 💤 ±0  0 ❌ ±0 
10 577 runs  +70  10 535 ✔️ +70  42 💤 ±0  0 ❌ ±0 

Results for commit 90ccb63. ± Comparison against base commit d26a5f8.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 10, 2024 •
edited
Loading

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (d26a5f8)Merge (522d79a)Diff
    aar161 kB161 kB+20 B (+0.0%)
    apk (aggressive)1.31 MB1.32 MB+12.9 kB (+1.0%)
    apk (release)9.30 MB9.32 MB+16.9 kB (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MuW77MfYmB.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 10, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.20% (d26a5f8) to 50.19% (522d79a) by -0.01%.

    FilenameBase (d26a5f8)Merge (522d79a)Diff
    DoubleNode.java100.00%88.24%-11.76%
    ViewProcessor.java91.79%92.10%+0.30%

  • firebase-firestore

    Overall coverage changed from 45.89% (d26a5f8) to 45.89% (522d79a) by +0.00%.

    FilenameBase (d26a5f8)Merge (522d79a)Diff
    DeleteMutation.java90.48%95.24%+4.76%

  • firebase-installations

    Overall coverage changed from ? (d26a5f8) to 58.68% (522d79a) by ?.

    23 individual files with coverage change

    FilenameBase (d26a5f8)Merge (522d79a)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    Installations.kt?40.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-messaging

    Overall coverage changed from 84.26% (d26a5f8) to 84.22% (522d79a) by -0.04%.

    FilenameBase (d26a5f8)Merge (522d79a)Diff
    FirebaseMessaging.java76.40%76.00%-0.40%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bm9Gj4XVzf.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 10, 2024 •
edited
Loading

Startup Time Report 1

The report is too large (122,587 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FUItPJ60KI/index.html

@tanzimfh tanzimfh force-pushed the tanzim/vertex-tests branch 11 times, most recently from 64dd514 to 70dcc7d Compare July 12, 2024 17:56
@tanzimfh tanzimfh force-pushed the tanzim/vertex-tests branch from 70dcc7d to 90ccb63 Compare July 15, 2024 19:31
@tanzimfh tanzimfh marked this pull request as ready for review July 15, 2024 20:26
@tanzimfh tanzimfh requested review from rlazo and davidmotson July 15, 2024 20:31
@tanzimfh tanzimfh merged commit 4db5dc8 into main Jul 15, 2024
174 checks passed
@tanzimfh tanzimfh deleted the tanzim/vertex-tests branch July 15, 2024 21:05
@firebase firebase locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@davidmotson davidmotson davidmotson approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanzimfh @google-oss-bot @rlazo @davidmotson