Add FirestoreClientProvider #6050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor' into tomandersen/componentProviderRefactor
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
…ClientProvider # Conflicts: # firebase-firestore/src/main/java/com/google/firebase/firestore/core/ComponentProvider.java # firebase-firestore/src/main/java/com/google/firebase/firestore/core/MemoryComponentProvider.java # firebase-firestore/src/main/java/com/google/firebase/firestore/core/SQLiteComponentProvider.java # firebase-firestore/src/test/java/com/google/firebase/firestore/FirebaseFirestoreIntegrationTestFactory.java
wu-hui
reviewed
Jul 19, 2024
firebase-firestore/src/main/java/com/google/firebase/firestore/DocumentReference.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/FirestoreClientProvider.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/core/FirestoreClient.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/core/FirestoreClient.java
Outdated
Show resolved
Hide resolved
wu-hui
approved these changes
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce FirestoreClientProvider to manage life cycle and access to FirestoreClient. Calls to FirestoreClient are made through the reference held in FirestoreClientProvider, thereby preparing for swapping FirestoreClient in future PR. This requires rewiring calls, such that code does not hold a direct reference to FirestoreClient.
I am open to a better name than FirestoeClientProvider...