Skip to content

Inject firebase common executors to Crashlytics #6019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Jun 6, 2024

According to the documentation here. Inject Firebase common executors for later refactor work.

Crashlytics will need at least 2 types of executors: background(for disk I/O writes), blocking(networking calls).

Note: all changes later will also merge to the feature branch: crashlytics-exception-handler

#no-changelog

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 6, 2024

@themiswang themiswang requested a review from mrober June 6, 2024 18:22
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Unit Test Results

  6 files  +  6    6 suites  +6   20s ⏱️ +20s
19 tests +19  19 ✔️ +19  0 💤 ±0  0 ±0 
38 runs  +38  38 ✔️ +38  0 💤 ±0  0 ±0 

Results for commit 7849d56. ± Comparison against base commit 7a313c3.

♻️ This comment has been updated with latest results.

@themiswang themiswang marked this pull request as ready for review June 6, 2024 18:27
@themiswang themiswang merged commit 70bf602 into crashlytics-exception-handler Jun 7, 2024
23 of 26 checks passed
@themiswang themiswang deleted the executorsInjection branch June 7, 2024 13:02
themiswang added a commit that referenced this pull request Jul 3, 2024
According to the documentation
[here](https://firebase.github.io/firebase-android-sdk/components/executors/).
Inject Firebase common executors for later refactor work.

Crashlytics will need at least 2 types of executors: background(for disk
I/O writes), blocking(networking calls).

Note: all changes later will also merge to the feature branch:
`crashlytics-exception-handler`
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants