Skip to content

Add dataconnect to ignore in the bom #6004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024
Merged

Add dataconnect to ignore in the bom #6004

merged 1 commit into from
May 30, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented May 30, 2024

No description provided.

Copy link
Contributor

github-actions bot commented May 30, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

buildSrc Test Results

37 tests   37 ✔️  1m 10s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit 9de4971.

Copy link
Contributor

Unit Test Results

     921 files  +     899       921 suites  +899   33m 39s ⏱️ + 32m 58s
  5 205 tests +  5 090    5 184 ✔️ +  5 070  21 💤 +20  0 ±0 
10 398 runs  +10 146  10 356 ✔️ +10 106  42 💤 +40  0 ±0 

Results for commit 9de4971. ± Comparison against base commit a5c4031.

@rlazo rlazo merged commit 8846009 into master May 30, 2024
164 of 175 checks passed
@rlazo rlazo deleted the rl.bom.dataconnect branch May 30, 2024 17:10
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.15% (a5c4031) to 50.22% (63683b6) by +0.08%.

    FilenameBase (a5c4031)Merge (63683b6)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    DoubleNode.java88.24%100.00%+11.76%
    QueryParams.java89.76%90.36%+0.60%
  • firebase-firestore

    Overall coverage changed from 44.76% (a5c4031) to 44.77% (63683b6) by +0.02%.

    FilenameBase (a5c4031)Merge (63683b6)Diff
    LruGarbageCollector.java93.64%97.27%+3.64%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java97.22%94.44%-2.78%
  • firebase-messaging

    Overall coverage changed from 84.26% (a5c4031) to 84.11% (63683b6) by -0.15%.

    FilenameBase (a5c4031)Merge (63683b6)Diff
    FirebaseMessaging.java76.40%76.00%-0.40%
    Metadata.java41.27%36.51%-4.76%
  • firebase-ml-modeldownloader

    Overall coverage changed from 83.32% (a5c4031) to 83.38% (63683b6) by +0.06%.

    FilenameBase (a5c4031)Merge (63683b6)Diff
    FirebaseModelDownloader.java84.05%84.66%+0.61%
  • firebase-storage

    Overall coverage changed from 84.04% (a5c4031) to 84.08% (63683b6) by +0.04%.

    FilenameBase (a5c4031)Merge (63683b6)Diff
    StreamDownloadTask.java88.41%88.89%+0.48%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VjTfQeJoUC.html

@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants