Skip to content

Experimental namespacing #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Experimental namespacing #60

wants to merge 1 commit into from

Conversation

ashwinraghav
Copy link
Contributor

@ashwinraghav ashwinraghav commented Oct 4, 2018 •
edited
Loading

This is supposed to fix #59. But, I see that the R.txt files in the published aar still contain transitive resources.

Steps to repro

./gradlew clean :firebase-firestore:publishToMavenLocal
jar xf ~/.m2/repository/com/google/firebase/firebase-firestore/17.1.2-SNAPSHOT/firebase-firestore-17.1.2-SNAPSHOT.aar
vi R.txt

I was hoping to get an extra pair of eyes.

@saurabhdtu saurabhdtu mentioned this pull request Nov 20, 2018
Closed
@vkryachko vkryachko changed the title Experimental namespacing Experimental namespacing Experimental namespacing Experimental namespacing May 17, 2019
@vkryachko vkryachko changed the title Experimental namespacing Experimental namespacing Experimental namespacing Experimental namespacing May 17, 2019
@vkryachko vkryachko removed their request for review May 21, 2019 21:26
@vkryachko vkryachko closed this Jul 8, 2019
@vkryachko vkryachko deleted the namespace branch July 8, 2019 17:31
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bjornick bjornick Awaiting requested review from bjornick

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R.txt files contain transitive resources
3 participants
@ashwinraghav @vkryachko @google-oss-bot