Skip to content

Fix JavaStyle violations for Storage #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2019
Merged

Fix JavaStyle violations for Storage #593

merged 1 commit into from
Jul 10, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

Continuing my quest to fix the violations reported in https://critique.corp.google.com/#review/257313292

@googlebot googlebot added the cla: yes Override cla label Jul 10, 2019
wilhuff
wilhuff approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian schmidt-sebastian merged commit 38ad4b0 into master Jul 10, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixstorage branch July 15, 2019 23:14
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schmidt-sebastian @wilhuff @VinayGuthal @googlebot @google-oss-bot