Skip to content

Fix typo in Storage test #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2019
Merged

Fix typo in Storage test #592

merged 1 commit into from
Jul 10, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

This causes a CommonTypo validation failure in the Copybara CL 257313292

@schmidt-sebastian
Fix typo
b0422da 
This causes a CommonTypo validation failure in the Copybara CL 257313292
@googlebot googlebot added the cla: yes Override cla label Jul 10, 2019
@schmidt-sebastian
Copy link
Contributor Author

Hey reviewers! Can I get an LGTM for this one line change if one of you is still up? :)

wilhuff
wilhuff approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian schmidt-sebastian merged commit 22f1342 into master Jul 10, 2019
@schmidt-sebastian schmidt-sebastian deleted the schmidt-sebastian-patch-1 branch July 10, 2019 01:53
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@schmidt-sebastian @wilhuff @googlebot @thebrianchen @var-const @rsgowman @google-oss-bot