Skip to content

Upgrade lint version to resolve kotlin test error #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

emilypgoogle
Copy link
Collaborator

Originally looked into changing the test, eventually decided to just bump the version with a fix. I went for the latest non-alpha version of android lint as a bump, this seems to resolve the test with no negative consequences.

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Unit Test Results

     950 files  +     948       950 suites  +948   35m 25s ⏱️ + 35m 13s
  5 216 tests +  5 212    5 194 ✔️ +  5 190  22 💤 +22  0 ±0 
10 517 runs  +10 509  10 473 ✔️ +10 465  44 💤 +44  0 ±0 

Results for commit 491bfe6. ± Comparison against base commit d8af001.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2024

Coverage Report 1

Affected Products

  • firebase-installations

    Overall coverage changed from ? (d8af001) to 58.68% (7fb63cd) by ?.

    23 individual files with coverage change

    FilenameBase (d8af001)Merge (7fb63cd)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    Installations.kt?40.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-messaging

    Overall coverage changed from 84.14% (d8af001) to 84.33% (7fb63cd) by +0.19%.

    FilenameBase (d8af001)Merge (7fb63cd)Diff
    FirebaseMessaging.java76.40%77.20%+0.80%
    Metadata.java36.51%41.27%+4.76%
  • firebase-storage

    Overall coverage changed from 84.08% (d8af001) to 84.12% (7fb63cd) by +0.04%.

    FilenameBase (d8af001)Merge (7fb63cd)Diff
    UploadTask.java81.52%81.85%+0.33%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TFZYO9nPFQ.html

@google-oss-bot
Copy link
Contributor

@emilypgoogle emilypgoogle merged commit 68fb692 into master Apr 24, 2024
158 of 171 checks passed
@emilypgoogle emilypgoogle deleted the ep/tools-lint-fix branch April 24, 2024 18:14
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2024

Startup Time Report 1

The report is too large (122,536 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0RVvxGJYe7/index.html

@firebase firebase locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants