Http client in Firebase Segmentation SDK to call backend service. #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache and update to Firebase Segmentation backend. CL also contains unit tests. (The http client is not implemented yet.)
2. Some fixes for the http request format
vkryachko
reviewed
Jul 9, 2019
...ntation/src/main/java/com/google/firebase/segmentation/remote/SegmentationServiceClient.java
Outdated
Show resolved
Hide resolved
entire synchronous code block in async task.
|
Changed okhttpclient to httpsUrlConnection |
vkryachko
reviewed
Jul 11, 2019
...ntation/src/main/java/com/google/firebase/segmentation/remote/SegmentationServiceClient.java
Outdated
Show resolved
Hide resolved
...ntation/src/main/java/com/google/firebase/segmentation/remote/SegmentationServiceClient.java
Outdated
Show resolved
Hide resolved
vkryachko
reviewed
Jul 22, 2019
| @@ -36,12 +39,14 @@ | |||
| private final FirebaseInstanceId firebaseInstanceId; | |||
| private final CustomInstallationIdCache localCache; | |||
| private final SegmentationServiceClient backendServiceClient; | |||
| private final Executor executor; | |||
|
|
|||
| FirebaseSegmentation(FirebaseApp firebaseApp) { | |||
There was a problem hiding this comment.
Could this constructor delegate to the one below?
| } | ||
| TaskCompletionSource<Void> taskCompletionSource = new TaskCompletionSource<>(); | ||
|
|
||
| executor.execute( |
There was a problem hiding this comment.
2 points:
- There is a dedicated
Tasks.call(executor, callable)to achieve this effect - Consider extracting the lambda below into its own (private) method that you can annotate with
@WorkerThread
This applies to the here and throughout as well
There was a problem hiding this comment.
Very good learning!
Done
firebase-segmentation/src/main/java/com/google/firebase/segmentation/FirebaseSegmentation.java
Outdated
Show resolved
Hide resolved
...ntation/src/main/java/com/google/firebase/segmentation/remote/SegmentationServiceClient.java
Outdated
Show resolved
Hide resolved
vkryachko
approved these changes
Jul 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proto is defined in https://cs.corp.google.com/piper///depot/google3/google/firebase/segmentation/v1alpha/segmentation_service.proto