Move DocumentId to public space #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test device-check-changed |
ghost
force-pushed
the
wuandy/DocumentIdGoesPublic
branch
from
8c0e7da to
ad38eb4
Compare
ghost
assigned 
mikelehen
suggested changes
Jun 26, 2019
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/POJOTest.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/POJOTest.java
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/DocumentId.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/DocumentId.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/DocumentId.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/DocumentId.java
Outdated
Show resolved
Hide resolved
mikelehen
suggested changes
Jun 26, 2019
There was a problem hiding this comment.
Suuper close, but I just remembered that we should add a firebase-firestore/CHANGELOG.md entry for this now that it's going to be public (which will then get pulled into https://firebase.google.com/support/release-notes/android). Sorry!
|
CHANGELOG added. |
schmidt-sebastian
pushed a commit
that referenced
this pull request
Jun 27, 2019
* Move DocumentId to public space * add nest object testing * add changelog
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.