Skip to content

Fix offline transport handling. #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

Fix offline transport handling. #537

merged 1 commit into from
Jun 19, 2019

Conversation

vkryachko
Copy link
Member

When the device is offline its active NetworkInfo is null, this causes
an NPE and fails to record events.

@vkryachko
Fix offline transport handling.
a2ef271 
When the device is offline its active NetworkInfo is null, this causes
an NPE and fails to record events.
@vkryachko vkryachko requested review from ashwinraghav and MeghaB June 19, 2019 16:27
@googlebot googlebot added the cla: yes Override cla label Jun 19, 2019
MeghaB
MeghaB approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@MeghaB MeghaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vkryachko vkryachko merged commit 8eb2e7e into master Jun 19, 2019
@vkryachko vkryachko deleted the vk.transport_offline_fix branch July 8, 2019 17:30
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashwinraghav ashwinraghav ashwinraghav approved these changes

@MeghaB MeghaB MeghaB approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vkryachko @ashwinraghav @MeghaB @googlebot @google-oss-bot