Restrict coverage collection to release builds. #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage can fail for local builds, becuase there are multiple definitions for the same classes (debug and release). On CI, debug is disabled. This change forces the coverage check to use on release builds, thus making it compatible with both local and CI use cases. This fixes the problem presented in #531.
yifanyang
approved these changes
Jun 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code coverage can fail for local builds, becuase there are multiple
definitions for the same classes (debug and release). On CI, debug is
disabled. This change forces the coverage check to use on release
builds, thus making it compatible with both local and CI use cases.
This fixes the problem presented in #531.